libsql: offline sync batch write_metadata

Author: LucioFranco

libsql/src/local/database.rs

@@ -423,6 +423,8 @@ impl Database {
             frame_no += 1;
         }
 
+        sync_ctx.write_metadata().await?;
+
         // TODO(lucio): this can underflow if the server previously returned a higher max_frame_no
         // than what we have stored here.
         let frame_count = end_frame_no - start_frame_no + 1;

libsql/src/sync.rs

@@ -120,8 +120,6 @@ impl SyncContext {
         // Update our last known max_frame_no from the server.
         self.durable_frame_num = durable_frame_num;
 
-        self.write_metadata().await?;
-
         Ok(durable_frame_num)
     }
 
@@ -193,7 +191,7 @@ impl SyncContext {
         self.generation
     }
 
-    async fn write_metadata(&mut self) -> Result<()> {
+    pub(crate) async fn write_metadata(&mut self) -> Result<()> {
         let path = format!("{}-info", self.db_path);
 
         let mut metadata = MetadataJson {

libsql/src/sync/test.rs

@@ -28,6 +28,7 @@ async fn test_sync_context_push_frame() {
 
     // Push a frame and verify the response
     let durable_frame = sync_ctx.push_one_frame(frame, 1, 0).await.unwrap();
+    sync_ctx.write_metadata().await.unwrap();
     assert_eq!(durable_frame, 1); // First frame should return max_frame_no = 1
 
     // Verify internal state was updated
@@ -55,6 +56,7 @@ async fn test_sync_context_with_auth() {
     let mut sync_ctx = sync_ctx;
 
     let durable_frame = sync_ctx.push_one_frame(frame, 1, 0).await.unwrap();
+    sync_ctx.write_metadata().await.unwrap();
     assert_eq!(durable_frame, 1);
     assert_eq!(server.frame_count(), 1);
 }
@@ -80,6 +82,7 @@ async fn test_sync_context_multiple_frames() {
     for i in 0..3 {
         let frame = Bytes::from(format!("frame data {}", i));
         let durable_frame = sync_ctx.push_one_frame(frame, 1, i).await.unwrap();
+        sync_ctx.write_metadata().await.unwrap();
         assert_eq!(durable_frame, i + 1);
         assert_eq!(sync_ctx.durable_frame_num(), i + 1);
         assert_eq!(server.frame_count(), i + 1);
@@ -105,6 +108,7 @@ async fn test_sync_context_corrupted_metadata() {
     let mut sync_ctx = sync_ctx;
     let frame = Bytes::from("test frame data");
     let durable_frame = sync_ctx.push_one_frame(frame, 1, 0).await.unwrap();
+    sync_ctx.write_metadata().await.unwrap();
     assert_eq!(durable_frame, 1);
     assert_eq!(server.frame_count(), 1);