Skip to content

Commit 4feeffd

Browse files
committed
chore: remove deprecated group update argument
1 parent 4d43c0b commit 4feeffd

2 files changed

Lines changed: 2 additions & 14 deletions

File tree

tableauserverclient/server/endpoint/groups_endpoint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def update(
9393
elif as_job:
9494
url = "?".join([url, "asJob=True"])
9595

96-
update_req = RequestFactory.Group.update_req(group_item, None)
96+
update_req = RequestFactory.Group.update_req(group_item)
9797
server_response = self.put_request(url, update_req)
9898
logger.info("Updated group item (ID: {0})".format(group_item.id))
9999
if as_job:

tableauserverclient/server/request_factory.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -418,19 +418,7 @@ def create_ad_req(self, group_item: GroupItem) -> bytes:
418418
import_element.attrib["siteRole"] = group_item.minimum_site_role
419419
return ET.tostring(xml_request)
420420

421-
def update_req(self, group_item: GroupItem, default_site_role: Optional[str] = None) -> bytes:
422-
# (1/8/2021): Deprecated starting v0.15
423-
if default_site_role is not None:
424-
import warnings
425-
426-
warnings.simplefilter("always", DeprecationWarning)
427-
warnings.warn(
428-
'RequestFactory.Group.update_req(...default_site_role="") is deprecated, '
429-
"please set the minimum_site_role field of GroupItem",
430-
DeprecationWarning,
431-
)
432-
group_item.minimum_site_role = default_site_role
433-
421+
def update_req(self, group_item: GroupItem, ) -> bytes:
434422
xml_request = ET.Element("tsRequest")
435423
group_element = ET.SubElement(xml_request, "group")
436424

0 commit comments

Comments
 (0)