From c3ece0484e2ca9e5ce9064769de43f2d9001f83e Mon Sep 17 00:00:00 2001 From: Kamal Singh Rautela Date: Sun, 5 Apr 2026 00:41:29 +0530 Subject: [PATCH 1/5] bench: refactor to use string interpolation in stats/nanmax-by Signed-off-by: Kamal Singh Rautela --- .../stats/base/ndarray/nanmax-by/benchmark/benchmark.js | 8 ++------ .../@stdlib/stats/nanmax-by/benchmark/benchmark.assign.js | 6 +++--- .../@stdlib/stats/nanmax-by/benchmark/benchmark.js | 4 ++-- .../stats/strided/nanmax-by/benchmark/benchmark.js | 8 ++------ .../strided/nanmax-by/benchmark/benchmark.ndarray.js | 8 ++------ 5 files changed, 11 insertions(+), 23 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js index 337bd61b2d96..e0e8ff532761 100644 --- a/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js @@ -27,6 +27,7 @@ var bernoulli = require( '@stdlib/random/base/bernoulli' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); var ndarray = require( '@stdlib/ndarray/base/ctor' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var nanmaxBy = require( './../lib' ); @@ -109,11 +110,6 @@ function createBenchmark( len ) { // MAIN // -/** -* Main execution sequence. -* -* @private -*/ function main() { var len; var min; @@ -127,7 +123,7 @@ function main() { for ( i = min; i <= max; i++ ) { len = pow( 10, i ); f = createBenchmark( len ); - bench( pkg+':len='+len, f ); + bench( format( '%s:dtype=%s,len=%d', pkg, options.dtype, len ), f ); } } diff --git a/lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.assign.js b/lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.assign.js index 21a148853f2a..5e1da3a39753 100644 --- a/lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.assign.js +++ b/lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.assign.js @@ -21,12 +21,12 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var format = require( '@stdlib/string/format' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var pow = require( '@stdlib/math/base/special/pow' ); var uniform = require( '@stdlib/random/array/uniform' ); -var zeros = require( '@stdlib/array/zeros' ); var ndarray = require( '@stdlib/ndarray/base/ctor' ); +var zeros = require( '@stdlib/array/zeros' ); +var pow = require( '@stdlib/math/base/special/pow' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var nanmaxBy = require( './../lib' ); diff --git a/lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.js index 7db86d1852da..fe5040050839 100644 --- a/lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.js @@ -21,11 +21,11 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var format = require( '@stdlib/string/format' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var pow = require( '@stdlib/math/base/special/pow' ); var uniform = require( '@stdlib/random/array/uniform' ); var ndarray = require( '@stdlib/ndarray/base/ctor' ); +var pow = require( '@stdlib/math/base/special/pow' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var nanmaxBy = require( './../lib' ); diff --git a/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js index 3e45ce89a57f..4c4b8fea3324 100644 --- a/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js @@ -26,6 +26,7 @@ var filledarrayBy = require( '@stdlib/array/filled-by' ); var bernoulli = require( '@stdlib/random/base/bernoulli' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var nanmaxBy = require( './../lib/main.js' ); @@ -96,11 +97,6 @@ function createBenchmark( len ) { // MAIN // -/** -* Main execution sequence. -* -* @private -*/ function main() { var len; var min; @@ -114,7 +110,7 @@ function main() { for ( i = min; i <= max; i++ ) { len = pow( 10, i ); f = createBenchmark( len ); - bench( pkg+':len='+len, f ); + bench( format( '%s:len=%d', pkg, len ), f ); } } diff --git a/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js index 1573a3b9ee52..a6bd55b0a901 100644 --- a/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js @@ -26,6 +26,7 @@ var filledarrayBy = require( '@stdlib/array/filled-by' ); var bernoulli = require( '@stdlib/random/base/bernoulli' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var nanmaxBy = require( './../lib/ndarray.js' ); @@ -96,11 +97,6 @@ function createBenchmark( len ) { // MAIN // -/** -* Main execution sequence. -* -* @private -*/ function main() { var len; var min; @@ -114,7 +110,7 @@ function main() { for ( i = min; i <= max; i++ ) { len = pow( 10, i ); f = createBenchmark( len ); - bench( pkg+':ndarray:len='+len, f ); + bench( format( '%s:ndarray:len=%d', pkg, len ), f ); } } From a7d62a378dc7520129de5c2595ca7a7600250945 Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 10 Apr 2026 23:57:06 -0700 Subject: [PATCH 2/5] docs: restore JSDoc comment Signed-off-by: Athan --- .../stats/base/ndarray/nanmax-by/benchmark/benchmark.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js index e0e8ff532761..537899c439fb 100644 --- a/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js @@ -110,6 +110,11 @@ function createBenchmark( len ) { // MAIN // +/** +* Main execution sequence. +* +* @private +*/ function main() { var len; var min; From 06a862f76424e0c072dff920924386011dde255e Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 10 Apr 2026 23:57:38 -0700 Subject: [PATCH 3/5] Apply suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../stats/strided/nanmax-by/benchmark/benchmark.ndarray.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js index a6bd55b0a901..d886b650a940 100644 --- a/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js @@ -97,6 +97,11 @@ function createBenchmark( len ) { // MAIN // +/** +* Main execution sequence. +* +* @private +*/ function main() { var len; var min; From 3ecef14badc6287600fb13c43b446faa13deca6a Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 10 Apr 2026 23:58:00 -0700 Subject: [PATCH 4/5] Apply suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js index 4c4b8fea3324..9b4f97658f50 100644 --- a/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js @@ -97,6 +97,11 @@ function createBenchmark( len ) { // MAIN // +/** +* Main execution sequence. +* +* @private +*/ function main() { var len; var min; From 63b18884baf7ef448e69d13fa137aa84779fdc88 Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 11 Apr 2026 00:00:27 -0700 Subject: [PATCH 5/5] Apply suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js index 537899c439fb..772f08fbcc94 100644 --- a/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js @@ -128,7 +128,7 @@ function main() { for ( i = min; i <= max; i++ ) { len = pow( 10, i ); f = createBenchmark( len ); - bench( format( '%s:dtype=%s,len=%d', pkg, options.dtype, len ), f ); + bench( format( '%s:len=%d', pkg, len ), f ); } }