From be534b27212b9302f15d2ac704aa1d31cf9ab74c Mon Sep 17 00:00:00 2001 From: Prajjwal Bajpai Date: Fri, 6 Feb 2026 15:02:03 +0530 Subject: [PATCH 1/2] bench: refactor to use string interpolation in `lapack/base/iladlc` --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/lapack/base/iladlc/benchmark/benchmark.js | 3 ++- .../@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.js b/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.js index 1d123579f1e9..3d96940da4b8 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.js @@ -25,6 +25,7 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' ); var zeros = require( '@stdlib/array/zeros' ); var pow = require( '@stdlib/math/base/special/pow' ); var floor = require( '@stdlib/math/base/special/floor' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var iladlc = require( './../lib/iladlc.js' ); @@ -103,7 +104,7 @@ function main() { for ( i = min; i <= max; i++ ) { N = floor( pow( pow( 10, i ), 1.0/2.0 ) ); f = createBenchmark( ord, N ); - bench( pkg+'::square_matrix:order='+ord+',size='+(N*N), f ); + bench( format( '%s::square_matrix:order=%s,size=%d', pkg, ord, (N*N) ), f ); } } } diff --git a/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js index ae11e0e1308d..2b9a8d638f6e 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js @@ -26,6 +26,7 @@ var pow = require( '@stdlib/math/base/special/pow' ); var floor = require( '@stdlib/math/base/special/floor' ); var zeros = require( '@stdlib/array/zeros' ); var isColumnMajor = require( '@stdlib/ndarray/base/assert/is-column-major-string' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var iladlc = require( './../lib/ndarray.js' ); @@ -114,7 +115,7 @@ function main() { for ( i = min; i <= max; i++ ) { N = floor( pow( pow( 10, i ), 1.0/2.0 ) ); f = createBenchmark( ord, N ); - bench( pkg+'::square_matrix:ndarray:order='+ord+',size='+(N*N), f ); + bench( format( '%s::square_matrix:ndarray:order=%s,size=%d', pkg, ord, (N*N) ), f ); } } } From 6cd216df6e38d79b09b8209ab6107ffb11cb268c Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 22 Feb 2026 17:46:46 -0800 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/lapack/base/iladlc/benchmark/benchmark.js | 2 +- .../@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.js b/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.js index 3d96940da4b8..c70c754d00cd 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.js @@ -104,7 +104,7 @@ function main() { for ( i = min; i <= max; i++ ) { N = floor( pow( pow( 10, i ), 1.0/2.0 ) ); f = createBenchmark( ord, N ); - bench( format( '%s::square_matrix:order=%s,size=%d', pkg, ord, (N*N) ), f ); + bench( format( '%s::square_matrix:order=%s,size=%d', pkg, ord, N*N ), f ); } } } diff --git a/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js index 2b9a8d638f6e..b2a9013e7991 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlc/benchmark/benchmark.ndarray.js @@ -115,7 +115,7 @@ function main() { for ( i = min; i <= max; i++ ) { N = floor( pow( pow( 10, i ), 1.0/2.0 ) ); f = createBenchmark( ord, N ); - bench( format( '%s::square_matrix:ndarray:order=%s,size=%d', pkg, ord, (N*N) ), f ); + bench( format( '%s::square_matrix:ndarray:order=%s,size=%d', pkg, ord, N*N ), f ); } } }