From fb92e26eaed57cccaa821076a455ca71f98175e8 Mon Sep 17 00:00:00 2001 From: Prajjwal Bajpai Date: Thu, 5 Feb 2026 17:49:08 +0530 Subject: [PATCH 1/2] bench: refactor to use string interpolation in `lapack/base/claswp` --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/lapack/base/claswp/benchmark/benchmark.js | 3 ++- .../@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.js b/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.js index fb405c33bcfb..de474b5097de 100644 --- a/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.js @@ -27,6 +27,7 @@ var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); var pow = require( '@stdlib/math/base/special/pow' ); var floor = require( '@stdlib/math/base/special/floor' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var claswp = require( './../lib/claswp.js' ); @@ -120,7 +121,7 @@ function main() { j = 1; while ( j <= N ) { f = createBenchmark( ord, N, j ); - bench( pkg+'::square_matrix:order='+ord+',nrows='+j+',size='+(N*N), f ); + bench( format( '%s::square_matrix:order=%s,nrows=%d,size=%d', pkg, ord, j, (N*N) ), f ); j *= 2; } } diff --git a/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js index b3e8d7c74703..9e327cecab25 100644 --- a/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js @@ -28,6 +28,7 @@ var isColumnMajor = require( '@stdlib/ndarray/base/assert/is-column-major-string var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); var pow = require( '@stdlib/math/base/special/pow' ); var floor = require( '@stdlib/math/base/special/floor' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var claswp = require( './../lib/ndarray.js' ); @@ -130,7 +131,7 @@ function main() { j = 1; while ( j <= N ) { f = createBenchmark( ord, N, j ); - bench( pkg+'::square_matrix:ndarray:order='+ord+',nrows='+j+',size='+(N*N), f ); + bench( format( '%s::square_matrix:ndarray:order=%s,nrows=%d,size=%d', pkg, ord, j, (N*N) ), f ); j *= 2; } } From a1848834a402cab632d13e58d2955238d43d2b47 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 22 Feb 2026 17:55:18 -0800 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/lapack/base/claswp/benchmark/benchmark.js | 2 +- .../@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.js b/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.js index de474b5097de..c29253093d93 100644 --- a/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.js @@ -121,7 +121,7 @@ function main() { j = 1; while ( j <= N ) { f = createBenchmark( ord, N, j ); - bench( format( '%s::square_matrix:order=%s,nrows=%d,size=%d', pkg, ord, j, (N*N) ), f ); + bench( format( '%s::square_matrix:order=%s,nrows=%d,size=%d', pkg, ord, j, N*N ), f ); j *= 2; } } diff --git a/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js index 9e327cecab25..fb62d7ab06a8 100644 --- a/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/lapack/base/claswp/benchmark/benchmark.ndarray.js @@ -131,7 +131,7 @@ function main() { j = 1; while ( j <= N ) { f = createBenchmark( ord, N, j ); - bench( format( '%s::square_matrix:ndarray:order=%s,nrows=%d,size=%d', pkg, ord, j, (N*N) ), f ); + bench( format( '%s::square_matrix:ndarray:order=%s,nrows=%d,size=%d', pkg, ord, j, N*N ), f ); j *= 2; } }