Skip to content

Commit 2a9e3c5

Browse files
Om-A-osckgryte
andauthored
bench: refactor stats/base/dists/arcsine/cdf benchmarks
PR-URL: #9881 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
1 parent ecf4b7c commit 2a9e3c5

2 files changed

Lines changed: 25 additions & 30 deletions

File tree

lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/benchmark/benchmark.js

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var Float64Array = require( '@stdlib/array/float64' );
25-
var uniformArray = require( '@stdlib/random/array/uniform' );
26-
var uniform = require( '@stdlib/random/base/uniform' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
25+
var format = require( '@stdlib/string/format' );
2726
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2827
var pkg = require( './../package.json' ).name;
2928
var cdf = require( './../lib' );
@@ -32,26 +31,23 @@ var cdf = require( './../lib' );
3231
// MAIN //
3332

3433
bench( pkg, function benchmark( b ) {
35-
var len;
34+
var opts;
3635
var min;
3736
var max;
3837
var x;
3938
var y;
4039
var i;
4140

42-
len = 100;
43-
x = new Float64Array( len );
44-
min = new Float64Array( len );
45-
max = new Float64Array( len );
46-
for ( i = 0; i < len; i++ ) {
47-
x[ i ] = uniform( -10.0, 10.0 );
48-
min[ i ] = uniform( -20.0, 0.0 );
49-
max[ i ] = uniform( min[ i ], min[ i ] + 40.0 );
50-
}
41+
opts = {
42+
'dtype': 'float64'
43+
};
44+
x = uniform( 100, -10.0, 10.0, opts );
45+
min = uniform( 100, -20.0, 0.0, opts );
46+
max = uniform( 100, 20.0, 40.0, opts );
5147

5248
b.tic();
5349
for ( i = 0; i < b.iterations; i++ ) {
54-
y = cdf( x[ i % len ], min[ i % len ], max[ i % len ] );
50+
y = cdf( x[ i % x.length ], min[ i % min.length ], max[ i % max.length ] );
5551
if ( isnan( y ) ) {
5652
b.fail( 'should not return NaN' );
5753
}
@@ -64,7 +60,7 @@ bench( pkg, function benchmark( b ) {
6460
b.end();
6561
});
6662

67-
bench( pkg+':factory', function benchmark( b ) {
63+
bench( format( '%s::factory', pkg ), function benchmark( b ) {
6864
var mycdf;
6965
var min;
7066
var max;
@@ -75,7 +71,9 @@ bench( pkg+':factory', function benchmark( b ) {
7571
min = -1.5;
7672
max = 1.5;
7773
mycdf = cdf.factory( min, max );
78-
x = uniformArray( 100, -2.0, 2.0 );
74+
x = uniform( 100, -2.0, 2.0, {
75+
'dtype': 'float64'
76+
});
7977

8078
b.tic();
8179
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/benchmark/benchmark.native.js

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var Float64Array = require( '@stdlib/array/float64' );
26-
var uniform = require( '@stdlib/random/base/uniform' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
26+
var format = require( '@stdlib/string/format' );
2727
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2828
var tryRequire = require( '@stdlib/utils/try-require' );
2929
var pkg = require( './../package.json' ).name;
@@ -39,27 +39,24 @@ var opts = {
3939

4040
// MAIN //
4141

42-
bench( pkg+'::native', opts, function benchmark( b ) {
43-
var len;
42+
bench( format( '%s::native', pkg ), opts, function benchmark( b ) {
43+
var opts;
4444
var min;
4545
var max;
4646
var x;
4747
var y;
4848
var i;
4949

50-
len = 100;
51-
x = new Float64Array( len );
52-
min = new Float64Array( len );
53-
max = new Float64Array( len );
54-
for ( i = 0; i < len; i++ ) {
55-
x[ i ] = uniform( -10.0, 10.0 );
56-
min[ i ] = uniform( -20.0, 0.0 );
57-
max[ i ] = uniform( min[ i ], min[ i ] + 40.0 );
58-
}
50+
opts = {
51+
'dtype': 'float64'
52+
};
53+
x = uniform( 100, -10.0, 10.0, opts );
54+
min = uniform( 100, -20.0, 0.0, opts );
55+
max = uniform( 100, 20.0, 40.0, opts );
5956

6057
b.tic();
6158
for ( i = 0; i < b.iterations; i++ ) {
62-
y = cdf( x[ i % len ], min[ i % len ], max[ i % len ] );
59+
y = cdf( x[ i % x.length ], min[ i % min.length ], max[ i % max.length ] );
6360
if ( isnan( y ) ) {
6461
b.fail( 'should not return NaN' );
6562
}

0 commit comments

Comments
 (0)