Skip to content

Commit d74442a

Browse files
committed
Downgrade github.com/ncruces/go-sqlite3 to v0.32.0
v0.33 of ncruces/go-sqlite3 replaced its embedded wasm runtime with a pure-Go translation provided by the new github.com/ncruces/go-sqlite3-wasm module. That module exposes an Xenv interface that v0.33.3's wrap.go fails to satisfy (missing Xstrtol), so any downstream build pulling these versions together fails to compile. Pin back to v0.32.0, which ships its wasm runtime via the github.com/ncruces/go-sqlite3/embed subpackage, and restore the blank imports that wire the embedded binary into sqlite3.Binary at init time. Fixes #4399
1 parent ca8dbe9 commit d74442a

File tree

6 files changed

+7
-6
lines changed

6 files changed

+7
-6
lines changed

go.mod

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ require (
1515
github.com/jackc/pgx/v5 v5.9.2
1616
github.com/jinzhu/inflection v1.0.0
1717
github.com/lib/pq v1.12.3
18-
github.com/ncruces/go-sqlite3 v0.33.3
18+
github.com/ncruces/go-sqlite3 v0.32.0
1919
github.com/pganalyze/pg_query_go/v6 v6.2.2
2020
github.com/pingcap/tidb/pkg/parser v0.0.0-20260418072757-ce92298d1124
2121
github.com/riza-io/grpc-go v0.2.0
@@ -39,7 +39,6 @@ require (
3939
github.com/jackc/pgpassfile v1.0.0 // indirect
4040
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
4141
github.com/jackc/puddle/v2 v2.2.2 // indirect
42-
github.com/ncruces/go-sqlite3-wasm v1.1.1-0.20260409221933-87e4b35a38d0 // indirect
4342
github.com/ncruces/julianday v1.0.0 // indirect
4443
github.com/pingcap/errors v0.11.5-0.20250523034308-74f78ae071ee // indirect
4544
github.com/pingcap/failpoint v0.0.0-20240528011301-b51a646c7c86 // indirect

go.sum

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,8 @@ github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
5151
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
5252
github.com/lib/pq v1.12.3 h1:tTWxr2YLKwIvK90ZXEw8GP7UFHtcbTtty8zsI+YjrfQ=
5353
github.com/lib/pq v1.12.3/go.mod h1:/p+8NSbOcwzAEI7wiMXFlgydTwcgTr3OSKMsD2BitpA=
54-
github.com/ncruces/go-sqlite3 v0.33.3 h1:6jCR3KuGvJSEwhaQrkHDGeIe2qCQ6nOUDNsPz7ZIotw=
55-
github.com/ncruces/go-sqlite3 v0.33.3/go.mod h1:t2Osfw0wcKzJTgv2EvrkTtVLqlbKTA5Yvwb2ypAlBcY=
56-
github.com/ncruces/go-sqlite3-wasm v1.1.1-0.20260409221933-87e4b35a38d0 h1:ymE9H30x1AyW5VfMNkJC9teuI2W1jjMsQS7kc6zl6Tg=
57-
github.com/ncruces/go-sqlite3-wasm v1.1.1-0.20260409221933-87e4b35a38d0/go.mod h1:/H3+JykPsfSlvKbOxNSx9kKwm3ecqQGzyCs1e9KkNsU=
54+
github.com/ncruces/go-sqlite3 v0.32.0 h1:hNBUXp88LrfQCsuyXLqWTbTUG35sUuktDsqhhgHvU20=
55+
github.com/ncruces/go-sqlite3 v0.32.0/go.mod h1:MIWTK60ONDl0oVY073zYvJP21C3Dly6P9bxVpgkLwdQ=
5856
github.com/ncruces/julianday v1.0.0 h1:fH0OKwa7NWvniGQtxdJRxAgkBMolni2BjDHaWTxqt7M=
5957
github.com/ncruces/julianday v1.0.0/go.mod h1:Dusn2KvZrrovOMJuOt0TNXL6tB7U2E8kvza5fFc9G7g=
6058
github.com/pganalyze/pg_query_go/v6 v6.2.2 h1:O0L6zMC226R82RF3X5n0Ki6HjytDsoAzuzp4ATVAHNo=

internal/cmd/vet_sqlite.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ package cmd
22

33
import (
44
_ "github.com/ncruces/go-sqlite3/driver"
5+
_ "github.com/ncruces/go-sqlite3/embed"
56
)

internal/engine/sqlite/analyzer/analyze.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"sync"
88

99
"github.com/ncruces/go-sqlite3"
10+
_ "github.com/ncruces/go-sqlite3/embed"
1011

1112
core "github.com/sqlc-dev/sqlc/internal/analysis"
1213
"github.com/sqlc-dev/sqlc/internal/config"

internal/sqltest/sqlite.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"testing"
88

99
_ "github.com/ncruces/go-sqlite3/driver"
10+
_ "github.com/ncruces/go-sqlite3/embed"
1011

1112
"github.com/sqlc-dev/sqlc/internal/sql/sqlpath"
1213
)

internal/x/expander/expander_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"github.com/go-sql-driver/mysql"
1212
"github.com/jackc/pgx/v5/pgxpool"
1313
"github.com/ncruces/go-sqlite3"
14+
_ "github.com/ncruces/go-sqlite3/embed"
1415

1516
"github.com/sqlc-dev/sqlc/internal/engine/dolphin"
1617
"github.com/sqlc-dev/sqlc/internal/engine/postgresql"

0 commit comments

Comments
 (0)