Skip to content

Commit 89e1f6e

Browse files
authored
fix xgboost training with greater than 255 feature columns (#2774)
1 parent 844989e commit 89e1f6e

5 files changed

Lines changed: 9 additions & 5 deletions

File tree

go/codegen/xgboost/codegen.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ func deriveFeatureColumnCodeAndFieldDescs(fcs []ir.FeatureColumn, labelFc ir.Fea
228228
}
229229
}
230230

231-
featureColumnsCode = strings.Join(fcCodes, ",")
231+
featureColumnsCode = strings.Join(fcCodes, ",\n")
232232

233233
switch c := labelFc.(type) {
234234
case *ir.NumericColumn:

go/codegen/xgboost/template_evaluate.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ feature_column_names = [{{range .FeatureColumnNames}}
4646
"{{.}}",
4747
{{end}}]
4848
49-
transform_fn = xgboost_extended.feature_column.ComposedColumnTransformer(feature_column_names, {{.FeatureColumnCode}})
49+
feature_column_list = [{{.FeatureColumnCode}}]
50+
transform_fn = xgboost_extended.feature_column.ComposedColumnTransformer(feature_column_names, *feature_column_list)
5051
5152
evaluate(datasource='''{{.DataSource}}''',
5253
select='''{{.PredSelect}}''',

go/codegen/xgboost/template_explain.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ feature_column_names = [{{range .FeatureColumnNames}}
4242
"{{.}}",
4343
{{end}}]
4444
45-
transform_fn = xgboost_extended.feature_column.ComposedColumnTransformer(feature_column_names, {{.FeatureColumnCode}})
45+
feature_column_list = [{{.FeatureColumnCode}}]
46+
transform_fn = xgboost_extended.feature_column.ComposedColumnTransformer(feature_column_names, *feature_column_list)
4647
4748
explain(
4849
datasource='''{{.DataSource}}''',

go/codegen/xgboost/template_pred.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ feature_column_names = [{{range .FeatureColumnNames}}
4747
"{{.}}",
4848
{{end}}]
4949
50-
transform_fn = xgboost_extended.feature_column.ComposedColumnTransformer(feature_column_names, {{.FeatureColumnCode}})
50+
feature_column_list = [{{.FeatureColumnCode}}]
51+
transform_fn = xgboost_extended.feature_column.ComposedColumnTransformer(feature_column_names, *feature_column_list)
5152
5253
pred(datasource='''{{.DataSource}}''',
5354
select='''{{.PredSelect}}''',

go/codegen/xgboost/template_train.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ feature_column_names = [{{range .FeatureColumnNames}}
6464
6565
# NOTE: in the current implementation, we are generating a transform_fn from COLUMN clause.
6666
# The transform_fn is executed during the process of dumping the original data into DMatrix SVM file.
67-
transform_fn = xgboost_extended.feature_column.ComposedColumnTransformer(feature_column_names, {{.FeatureColumnCode}})
67+
feature_column_list = [{{.FeatureColumnCode}}]
68+
transform_fn = xgboost_extended.feature_column.ComposedColumnTransformer(feature_column_names, *feature_column_list)
6869
6970
train(datasource='''{{.DataSource}}''',
7071
select='''{{.TrainSelect}}''',

0 commit comments

Comments
 (0)