Update CDP Mode

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -1503,6 +1503,10 @@ def is_attribute_present(
     ):
         """Returns True if the element attribute/value is found.
         If the value is not specified, the attribute only needs to exist."""
+        if self.__is_cdp_swap_needed():
+            return self.cdp.is_attribute_present(
+                selector, attribute, value=value
+            )
         self.wait_for_ready_state_complete()
         time.sleep(0.01)
         selector, by = self.__recalculate_selector(selector, by)

seleniumbase/fixtures/page_actions.py

@@ -193,6 +193,10 @@ def is_attribute_present(
     @Returns
     Boolean (is attribute present)
     """
+    if __is_cdp_swap_needed(driver):
+        return driver.cdp.is_attribute_present(
+            selector, attribute, value=value
+        )
     _reconnect_if_disconnected(driver)
     try:
         element = driver.find_element(by=by, value=selector)

seleniumbase/undetected/cdp_driver/browser.py

@@ -350,7 +350,8 @@ async def get(
             if _cdp_geolocation:
                 await connection.send(cdp.page.navigate("about:blank"))
                 await connection.set_geolocation(_cdp_geolocation)
-            # Use the tab to navigate to new url
+            # This part isn't needed now, but may be needed later
+            """
             if (
                 hasattr(sb_config, "_cdp_proxy")
                 and "@" in sb_config._cdp_proxy
@@ -360,17 +361,14 @@ async def get(
                 username_and_password = sb_config._cdp_proxy.split("@")[0]
                 proxy_user = username_and_password.split(":")[0]
                 proxy_pass = username_and_password.split(":")[1]
-                await connection.set_auth(
-                    proxy_user, proxy_pass, self.tabs[0]
-                )
+                await connection.set_auth(proxy_user, proxy_pass, self.tabs[0])
                 time.sleep(0.25)
-            elif "auth" in kwargs and kwargs["auth"] and ":" in kwargs["auth"]:
+            """
+            if "auth" in kwargs and kwargs["auth"] and ":" in kwargs["auth"]:
                 username_and_password = kwargs["auth"]
                 proxy_user = username_and_password.split(":")[0]
                 proxy_pass = username_and_password.split(":")[1]
-                await connection.set_auth(
-                    proxy_user, proxy_pass, self.tabs[0]
-                )
+                await connection.set_auth(proxy_user, proxy_pass, self.tabs[0])
                 time.sleep(0.25)
             frame_id, loader_id, *_ = await connection.send(
                 cdp.page.navigate(url)