Refactor click_if_visible(selector)

Author: mdmintz

seleniumbase/core/sb_cdp.py

@@ -793,9 +793,14 @@ def click_active_element(self):
 
     def click_if_visible(self, selector, timeout=0):
         if self.is_element_visible(selector):
+            with suppress(Exception):
+                self.click(selector, timeout=1)
+        else:
             with suppress(Exception):
                 element = self.find_element(selector, timeout=timeout)
+                self.sleep(0.1)
                 element.scroll_into_view()
+                self.sleep(0.1)
                 element.click()
                 self.__slow_mode_pause_if_set()
                 self.loop.run_until_complete(self.page.wait())

seleniumbase/fixtures/base_case.py

@@ -2425,6 +2425,7 @@ def click_if_visible(self, selector, by="css selector", timeout=0):
                 self.wait_for_element_visible(
                     selector, by=by, timeout=timeout
                 )
+                self.sleep(0.2)
             if self.is_element_visible(selector, by=by):
                 self.click(selector, by=by)