Skip to content

Commit ca33b81

Browse files
authored
feat(deps)!: bump http-proxy-middleware to 4.0.0-beta.3 (#200)
1 parent 49bdd3b commit ca33b81

3 files changed

Lines changed: 44 additions & 30 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"hono": "^4.12.14",
7171
"http-compression": "^1.1.3",
7272
"http-proxy": "^1.18.1",
73-
"http-proxy-middleware": "^3.0.5",
73+
"http-proxy-middleware": "4.0.0-beta.3",
7474
"ipaddr.js": "^2.3.0",
7575
"launch-editor": "^2.13.2",
7676
"nano-staged": "^0.9.0",

pnpm-lock.yaml

Lines changed: 21 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/e2e/allowed-hosts.test.js

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
const express = require('express');
22
const { rspack } = require('@rspack/core');
3-
const { createProxyMiddleware } = require('http-proxy-middleware');
3+
const {
4+
createProxyMiddleware,
5+
proxyEventsPlugin,
6+
} = require('http-proxy-middleware');
47
const { RspackDevServer: Server } = require('@rspack/dev-server');
58
const config = require('../fixtures/client-config/rspack.config');
69
const runBrowser = require('../helpers/run-browser');
@@ -327,14 +330,30 @@ describe('allowed hosts', () => {
327330

328331
function startProxy(callback) {
329332
const app = express();
333+
const hostHeader = `[${devServerHost}]:${devServerPort}`;
334+
const setProxyHost = (proxyReq) => {
335+
proxyReq.setHeader('host', hostHeader);
336+
};
330337

331338
app.use(
332339
'/',
333340
createProxyMiddleware({
334-
target: `http://[${devServerHost}]:${devServerPort}`,
341+
// http-proxy-middleware v4 fails on IPv6 string targets like
342+
// "http://[::1]:port". Use a structured target, then restore the
343+
// correct Host header for both HTTP and WS requests.
344+
target: {
345+
protocol: 'http:',
346+
hostname: devServerHost,
347+
port: devServerPort,
348+
},
335349
ws: true,
336350
changeOrigin: true,
337-
logger: console,
351+
ejectPlugins: true,
352+
plugins: [proxyEventsPlugin],
353+
on: {
354+
proxyReq: setProxyHost,
355+
proxyReqWs: setProxyHost,
356+
},
338357
}),
339358
);
340359

0 commit comments

Comments
 (0)