fea!t: remove internalIP methods (#121)

Author: chenjiahan

src/server.ts

@@ -302,16 +302,6 @@ class Server<
     }
   }
 
-  // TODO remove me in the next major release, we have `findIp`
-  static async internalIP(family: 'v4' | 'v6') {
-    return Server.findIp(family, false);
-  }
-
-  // TODO remove me in the next major release, we have `findIp`
-  static internalIPSync(family: 'v4' | 'v6') {
-    return Server.findIp(family, false);
-  }
-
   static async getHostname(hostname: Host) {
     if (hostname === 'local-ip') {
       return (

tests/e2e/allowed-hosts.test.js

@@ -1683,7 +1683,7 @@ describe('allowed hosts', () => {
     });
 
     it('should always allow value from the `host` options if options.allowedHosts is auto', async () => {
-      const networkIP = Server.internalIPSync('v4');
+      const networkIP = Server.findIp('v4', false);
       const options = {
         host: networkIP,
         allowedHosts: 'auto',

tests/e2e/web-socket-server-url.test.js

@@ -111,7 +111,7 @@ describe('web socket server URL', () => {
     it(`should work behind proxy, when hostnames are different and ports are same ("${webSocketServer}")`, async () => {
       const devServerHost = '127.0.0.1';
       const devServerPort = port1;
-      const proxyHost = Server.internalIPSync('v4');
+      const proxyHost = Server.findIp('v4', false);
       const proxyPort = port1;
 
       const compiler = rspack(config);
@@ -207,7 +207,7 @@ describe('web socket server URL', () => {
     it(`should work behind proxy, when hostnames are different and ports are different ("${webSocketServer}")`, async () => {
       const devServerHost = '127.0.0.1';
       const devServerPort = port1;
-      const proxyHost = Server.internalIPSync('v4');
+      const proxyHost = Server.findIp('v4', false);
       const proxyPort = port2;
 
       const compiler = rspack(config);
@@ -308,7 +308,7 @@ describe('web socket server URL', () => {
     it(`should work behind proxy, when the "host" option is "local-ip" and the "port" option is "auto" ("${webSocketServer}")`, async () => {
       process.env.RSPACK_DEV_SERVER_BASE_PORT = 40000;
 
-      const proxyHost = Server.internalIPSync('v4');
+      const proxyHost = Server.findIp('v4', false);
       const proxyPort = port2;
 
       const compiler = rspack(config);
@@ -1916,7 +1916,7 @@ describe('web socket server URL', () => {
     });
 
     it(`should work when "host" option is IPv4 ("${webSocketServer}")`, async () => {
-      const hostname = Server.internalIPSync('v4');
+      const hostname = Server.findIp('v4', false);
       const compiler = rspack(config);
       const devServerOptions = {
         webSocketServer,
@@ -1984,7 +1984,7 @@ describe('web socket server URL', () => {
     });
 
     it(`should work when "host" option is "local-ip" ("${webSocketServer}")`, async () => {
-      const hostname = Server.internalIPSync('v4');
+      const hostname = Server.findIp('v4', false);
       const compiler = rspack(config);
       const devServerOptions = {
         webSocketServer,
@@ -2053,7 +2053,7 @@ describe('web socket server URL', () => {
     });
 
     it(`should work when "host" option is "local-ipv4" ("${webSocketServer}")`, async () => {
-      const hostname = Server.internalIPSync('v4');
+      const hostname = Server.findIp('v4', false);
       const compiler = rspack(config);
       const devServerOptions = {
         webSocketServer,