Skip to content

Commit 0fbeec1

Browse files
authored
fix: move launch-editor to dev dependencies (#134)
1 parent 8b844e8 commit 0fbeec1

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
"express": "^5.2.1",
5959
"http-proxy-middleware": "^3.0.5",
6060
"ipaddr.js": "^2.3.0",
61-
"launch-editor": "^2.13.1",
6261
"p-retry": "^7.1.1",
6362
"serve-index": "^1.9.2",
6463
"webpack-dev-middleware": "^7.4.5",
@@ -83,6 +82,7 @@
8382
"css-loader": "^7.1.4",
8483
"hono": "^4.12.3",
8584
"http-proxy": "^1.18.1",
85+
"launch-editor": "^2.13.1",
8686
"nano-staged": "^0.9.0",
8787
"open": "^11.0.0",
8888
"prettier": "3.8.1",

pnpm-lock.yaml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rslib.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export default defineConfig({
99
output: {
1010
externals: {
1111
express: 'commonjs express',
12-
'launch-editor': 'commonjs launch-editor',
1312
'connect-history-api-fallback':
1413
'commonjs connect-history-api-fallback',
1514
'webpack-dev-middleware': 'commonjs webpack-dev-middleware',

src/server.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1678,7 +1678,7 @@ class Server<
16781678
middlewares.push({
16791679
name: 'rspack-dev-server-open-editor',
16801680
path: '/rspack-dev-server/open-editor',
1681-
middleware: (req: Request, res: Response, next: NextFunction) => {
1681+
middleware: async (req: Request, res: Response, next: NextFunction) => {
16821682
if (req.method !== 'GET' && req.method !== 'HEAD') {
16831683
next();
16841684
return;
@@ -1694,8 +1694,9 @@ class Server<
16941694
const fileName = params.get('fileName');
16951695

16961696
if (typeof fileName === 'string') {
1697-
const launchEditor = require('launch-editor');
1698-
1697+
const { default: launchEditor } = await import(
1698+
/* webpackChunkName: "launch-editor" */ 'launch-editor'
1699+
);
16991700
launchEditor(fileName);
17001701
}
17011702

0 commit comments

Comments
 (0)