More secure default creation mode

WyriHaximus · WyriHaximus · commit 9af243723a36 · 2017-05-27T19:02:06.000+02:00
diff --git a/src/AdapterInterface.php b/src/AdapterInterface.php
@@ -7,7 +7,7 @@
 
 interface AdapterInterface
 {
-    const CREATION_MODE = 'rwxrwx---';
+    const CREATION_MODE = 'rwxrw----';
 
     /**
      * Return the loop associated with this adapter.
diff --git a/tests/Adapters/DirectoryTest.php b/tests/Adapters/DirectoryTest.php
@@ -70,7 +70,7 @@ public function testCreate(LoopInterface $loop, FilesystemInterface $filesystem)
         $dir = $this->tmpDir . 'path';
         $this->await($filesystem->dir($dir)->createRecursive(), $loop);
         $this->assertTrue(file_exists($dir));
-        $this->assertSame('0770', substr(sprintf('%o', fileperms($dir)), -4));
+        $this->assertSame('0760', substr(sprintf('%o', fileperms($dir)), -4));
     }
 
     /**
diff --git a/tests/Adapters/FileTest.php b/tests/Adapters/FileTest.php
@@ -115,7 +115,7 @@ public function testCreate(LoopInterface $loop, FilesystemInterface $filesystem)
         $this->assertFileNotExists($tempFile);
         $this->await($filesystem->file($tempFile)->create(), $loop);
         $this->assertFileExists($tempFile);
-        $this->assertSame('0770', substr(sprintf('%o', fileperms($tempFile)), -4));
+        $this->assertSame('0760', substr(sprintf('%o', fileperms($tempFile)), -4));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`interface AdapterInterface`
`9`	`9`	`{`
`10`		`- const CREATION_MODE = 'rwxrwx---';`
	`10`	`+ const CREATION_MODE = 'rwxrw----';`
`11`	`11`
`12`	`12`	`/**`
`13`	`13`	`* Return the loop associated with this adapter.`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function testCreate(LoopInterface $loop, FilesystemInterface $filesystem)`
`70`	`70`	`$dir = $this->tmpDir . 'path';`
`71`	`71`	`$this->await($filesystem->dir($dir)->createRecursive(), $loop);`
`72`	`72`	`$this->assertTrue(file_exists($dir));`
`73`		`- $this->assertSame('0770', substr(sprintf('%o', fileperms($dir)), -4));`
	`73`	`+ $this->assertSame('0760', substr(sprintf('%o', fileperms($dir)), -4));`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ public function testCreate(LoopInterface $loop, FilesystemInterface $filesystem)`
`115`	`115`	`$this->assertFileNotExists($tempFile);`
`116`	`116`	`$this->await($filesystem->file($tempFile)->create(), $loop);`
`117`	`117`	`$this->assertFileExists($tempFile);`
`118`		`- $this->assertSame('0770', substr(sprintf('%o', fileperms($tempFile)), -4));`
	`118`	`+ $this->assertSame('0760', substr(sprintf('%o', fileperms($tempFile)), -4));`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`/**`