Skip to content

Commit adf8b46

Browse files
clueclue
committed
Remove all callable type hints for consistency and performance reasons
1 parent f6dbe84 commit adf8b46

8 files changed

Lines changed: 40 additions & 40 deletions

File tree

‎src/ExtEventLoop.php‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ function ($signal) {
6767
$this->createStreamCallback();
6868
}
6969

70-
public function addReadStream($stream, callable $listener)
70+
public function addReadStream($stream, $listener)
7171
{
7272
$key = (int) $stream;
7373

@@ -77,7 +77,7 @@ public function addReadStream($stream, callable $listener)
7777
}
7878
}
7979

80-
public function addWriteStream($stream, callable $listener)
80+
public function addWriteStream($stream, $listener)
8181
{
8282
$key = (int) $stream;
8383

@@ -124,7 +124,7 @@ private function removeStream($stream)
124124
}
125125
}
126126

127-
public function addTimer($interval, callable $callback)
127+
public function addTimer($interval, $callback)
128128
{
129129
$timer = new Timer($interval, $callback, false);
130130

@@ -133,7 +133,7 @@ public function addTimer($interval, callable $callback)
133133
return $timer;
134134
}
135135

136-
public function addPeriodicTimer($interval, callable $callback)
136+
public function addPeriodicTimer($interval, $callback)
137137
{
138138
$timer = new Timer($interval, $callback, true);
139139

@@ -150,17 +150,17 @@ public function cancelTimer(TimerInterface $timer)
150150
}
151151
}
152152

153-
public function futureTick(callable $listener)
153+
public function futureTick($listener)
154154
{
155155
$this->futureTickQueue->add($listener);
156156
}
157157

158-
public function addSignal($signal, callable $listener)
158+
public function addSignal($signal, $listener)
159159
{
160160
$this->signals->add($signal, $listener);
161161
}
162162

163-
public function removeSignal($signal, callable $listener)
163+
public function removeSignal($signal, $listener)
164164
{
165165
$this->signals->remove($signal, $listener);
166166
}

‎src/ExtLibevLoop.php‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ function ($signal) {
6363
);
6464
}
6565

66-
public function addReadStream($stream, callable $listener)
66+
public function addReadStream($stream, $listener)
6767
{
6868
if (isset($this->readEvents[(int) $stream])) {
6969
return;
@@ -79,7 +79,7 @@ public function addReadStream($stream, callable $listener)
7979
$this->readEvents[(int) $stream] = $event;
8080
}
8181

82-
public function addWriteStream($stream, callable $listener)
82+
public function addWriteStream($stream, $listener)
8383
{
8484
if (isset($this->writeEvents[(int) $stream])) {
8585
return;
@@ -115,7 +115,7 @@ public function removeWriteStream($stream)
115115
}
116116
}
117117

118-
public function addTimer($interval, callable $callback)
118+
public function addTimer($interval, $callback)
119119
{
120120
$timer = new Timer( $interval, $callback, false);
121121

@@ -134,7 +134,7 @@ public function addTimer($interval, callable $callback)
134134
return $timer;
135135
}
136136

137-
public function addPeriodicTimer($interval, callable $callback)
137+
public function addPeriodicTimer($interval, $callback)
138138
{
139139
$timer = new Timer($interval, $callback, true);
140140

@@ -157,17 +157,17 @@ public function cancelTimer(TimerInterface $timer)
157157
}
158158
}
159159

160-
public function futureTick(callable $listener)
160+
public function futureTick($listener)
161161
{
162162
$this->futureTickQueue->add($listener);
163163
}
164164

165-
public function addSignal($signal, callable $listener)
165+
public function addSignal($signal, $listener)
166166
{
167167
$this->signals->add($signal, $listener);
168168
}
169169

170-
public function removeSignal($signal, callable $listener)
170+
public function removeSignal($signal, $listener)
171171
{
172172
$this->signals->remove($signal, $listener);
173173
}

‎src/ExtLibeventLoop.php‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ function ($signal) {
8585
$this->createStreamCallback();
8686
}
8787

88-
public function addReadStream($stream, callable $listener)
88+
public function addReadStream($stream, $listener)
8989
{
9090
$key = (int) $stream;
9191

@@ -95,7 +95,7 @@ public function addReadStream($stream, callable $listener)
9595
}
9696
}
9797

98-
public function addWriteStream($stream, callable $listener)
98+
public function addWriteStream($stream, $listener)
9999
{
100100
$key = (int) $stream;
101101

@@ -144,7 +144,7 @@ private function removeStream($stream)
144144
}
145145
}
146146

147-
public function addTimer($interval, callable $callback)
147+
public function addTimer($interval, $callback)
148148
{
149149
$timer = new Timer($interval, $callback, false);
150150

@@ -153,7 +153,7 @@ public function addTimer($interval, callable $callback)
153153
return $timer;
154154
}
155155

156-
public function addPeriodicTimer($interval, callable $callback)
156+
public function addPeriodicTimer($interval, $callback)
157157
{
158158
$timer = new Timer($interval, $callback, true);
159159

@@ -174,17 +174,17 @@ public function cancelTimer(TimerInterface $timer)
174174
}
175175
}
176176

177-
public function futureTick(callable $listener)
177+
public function futureTick($listener)
178178
{
179179
$this->futureTickQueue->add($listener);
180180
}
181181

182-
public function addSignal($signal, callable $listener)
182+
public function addSignal($signal, $listener)
183183
{
184184
$this->signals->add($signal, $listener);
185185
}
186186

187-
public function removeSignal($signal, callable $listener)
187+
public function removeSignal($signal, $listener)
188188
{
189189
$this->signals->remove($signal, $listener);
190190
}

‎src/LoopInterface.php‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ interface LoopInterface
5151
* @param callable $listener Invoked when the stream is ready.
5252
* @see self::removeReadStream()
5353
*/
54-
public function addReadStream($stream, callable $listener);
54+
public function addReadStream($stream, $listener);
5555

5656
/**
5757
* [Advanced] Register a listener to be notified when a stream is ready to write.
@@ -106,7 +106,7 @@ public function addReadStream($stream, callable $listener);
106106
* @param callable $listener Invoked when the stream is ready.
107107
* @see self::removeWriteStream()
108108
*/
109-
public function addWriteStream($stream, callable $listener);
109+
public function addWriteStream($stream, $listener);
110110

111111
/**
112112
* Remove the read event listener for the given stream.
@@ -178,7 +178,7 @@ public function removeWriteStream($stream);
178178
*
179179
* @return TimerInterface
180180
*/
181-
public function addTimer($interval, callable $callback);
181+
public function addTimer($interval, $callback);
182182

183183
/**
184184
* Enqueue a callback to be invoked repeatedly after the given interval.
@@ -248,7 +248,7 @@ public function addTimer($interval, callable $callback);
248248
*
249249
* @return TimerInterface
250250
*/
251-
public function addPeriodicTimer($interval, callable $callback);
251+
public function addPeriodicTimer($interval, $callback);
252252

253253
/**
254254
* Cancel a pending timer.
@@ -314,7 +314,7 @@ public function cancelTimer(TimerInterface $timer);
314314
*
315315
* @return void
316316
*/
317-
public function futureTick(callable $listener);
317+
public function futureTick($listener);
318318

319319
/**
320320
* Register a listener to be notified when a signal has been caught by this process.
@@ -356,7 +356,7 @@ public function futureTick(callable $listener);
356356
*
357357
* @return void
358358
*/
359-
public function addSignal($signal, callable $listener);
359+
public function addSignal($signal, $listener);
360360

361361
/**
362362
* Removes a previously added signal listener.
@@ -372,7 +372,7 @@ public function addSignal($signal, callable $listener);
372372
*
373373
* @return void
374374
*/
375-
public function removeSignal($signal, callable $listener);
375+
public function removeSignal($signal, $listener);
376376

377377
/**
378378
* Run the event loop until there are no more tasks to perform.

‎src/SignalsHandler.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ final class SignalsHandler
1515
private $on;
1616
private $off;
1717

18-
public function __construct(LoopInterface $loop, callable $on, callable $off)
18+
public function __construct(LoopInterface $loop, $on, $off)
1919
{
2020
$this->loop = $loop;
2121
$this->on = $on;
@@ -30,7 +30,7 @@ public function __destruct()
3030
}
3131
}
3232

33-
public function add($signal, callable $listener)
33+
public function add($signal, $listener)
3434
{
3535
if (count($this->signals) == 0 && $this->timer === null) {
3636
/**
@@ -53,7 +53,7 @@ public function add($signal, callable $listener)
5353
$this->signals[$signal][] = $listener;
5454
}
5555

56-
public function remove($signal, callable $listener)
56+
public function remove($signal, $listener)
5757
{
5858
if (!isset($this->signals[$signal])) {
5959
return;

‎src/StreamSelectLoop.php‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ function ($signal) {
9090
);
9191
}
9292

93-
public function addReadStream($stream, callable $listener)
93+
public function addReadStream($stream, $listener)
9494
{
9595
$key = (int) $stream;
9696

@@ -100,7 +100,7 @@ public function addReadStream($stream, callable $listener)
100100
}
101101
}
102102

103-
public function addWriteStream($stream, callable $listener)
103+
public function addWriteStream($stream, $listener)
104104
{
105105
$key = (int) $stream;
106106

@@ -130,7 +130,7 @@ public function removeWriteStream($stream)
130130
);
131131
}
132132

133-
public function addTimer($interval, callable $callback)
133+
public function addTimer($interval, $callback)
134134
{
135135
$timer = new Timer($interval, $callback, false);
136136

@@ -139,7 +139,7 @@ public function addTimer($interval, callable $callback)
139139
return $timer;
140140
}
141141

142-
public function addPeriodicTimer($interval, callable $callback)
142+
public function addPeriodicTimer($interval, $callback)
143143
{
144144
$timer = new Timer($interval, $callback, true);
145145

@@ -153,12 +153,12 @@ public function cancelTimer(TimerInterface $timer)
153153
$this->timers->cancel($timer);
154154
}
155155

156-
public function futureTick(callable $listener)
156+
public function futureTick($listener)
157157
{
158158
$this->futureTickQueue->add($listener);
159159
}
160160

161-
public function addSignal($signal, callable $listener)
161+
public function addSignal($signal, $listener)
162162
{
163163
if ($this->pcntl === false) {
164164
throw new \BadMethodCallException('Event loop feature "signals" isn\'t supported by the "StreamSelectLoop"');
@@ -167,7 +167,7 @@ public function addSignal($signal, callable $listener)
167167
$this->signals->add($signal, $listener);
168168
}
169169

170-
public function removeSignal($signal, callable $listener)
170+
public function removeSignal($signal, $listener)
171171
{
172172
$this->signals->remove($signal, $listener);
173173
}

‎src/Tick/FutureTickQueue.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public function __construct()
2828
*
2929
* @param callable $listener The callback to invoke.
3030
*/
31-
public function add(callable $listener)
31+
public function add($listener)
3232
{
3333
$this->queue->enqueue($listener);
3434
}

‎src/Timer/Timer.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ final class Timer implements TimerInterface
2525
* @param callable $callback The callback that will be executed when this timer elapses
2626
* @param bool $periodic Whether the time is periodic
2727
*/
28-
public function __construct($interval, callable $callback, $periodic = false)
28+
public function __construct($interval, $callback, $periodic = false)
2929
{
3030
if ($interval < self::MIN_INTERVAL) {
3131
$interval = self::MIN_INTERVAL;

0 commit comments

Comments
 (0)