Skip to content

Commit 5c7ec2f

Browse files
committed
Update comments
1 parent dac7d3b commit 5c7ec2f

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

Lib/subprocess.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2067,8 +2067,7 @@ def _wait_pidfd(self, timeout):
20672067
pidfd = os.pidfd_open(self.pid, 0)
20682068
except OSError:
20692069
# May be:
2070-
# - ESRCH: no such process; waitpid() should still be
2071-
# able to return the status code.
2070+
# - ESRCH: no such process
20722071
# - EMFILE, ENFILE: too many open files (usually 1024)
20732072
# - ENODEV: anonymous inode filesystem not supported
20742073
# - EPERM, EACCES, ENOSYS: undocumented; may happen if

Lib/test/test_subprocess.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4097,7 +4097,7 @@ class FastWaitTestCase(BaseTestCase):
40974097

40984098
def assert_fast_waitpid_error(self, patch_point):
40994099
# Emulate a case where pidfd_open() (Linux) or kqueue()
4100-
# (BSD/macOS) fails. _busy_wait() should be used as fallback.
4100+
# (BSD/macOS) fails. Busy-poll wait should be used as fallback.
41014101
exc = OSError(errno.EMFILE, os.strerror(errno.EMFILE))
41024102
with mock.patch(patch_point, side_effect=exc) as m:
41034103
p = subprocess.Popen([sys.executable,
@@ -4117,7 +4117,7 @@ def test_wait_kqueue_error(self):
41174117

41184118
@unittest.skipIf(not CAN_USE_KQUEUE, reason="macOS / BSD only")
41194119
def test_kqueue_control_error(self):
4120-
# Emulate a case where kqueue.control() fails. _busy_wait()
4120+
# Emulate a case where kqueue.control() fails. Busy-poll wait
41214121
# should be used as fallback.
41224122
p = subprocess.Popen([sys.executable,
41234123
"-c", "import time; time.sleep(0.3)"])

0 commit comments

Comments
 (0)