fixup! Update _colorize.py

Author: pablogsal

Lib/_colorize.py

@@ -273,9 +273,13 @@ class LiveProfiler(ThemeSection):
     func_stack_fg: int = CursesColors.YELLOW
     func_shown_fg: int = CursesColors.MAGENTA
 
-    # Table header colors
+    # Table header colors (for sorted column highlight)
     sorted_header_fg: int = CursesColors.BLACK
-    sorted_header_bg: int = CursesColors.YELLOW
+    sorted_header_bg: int = CursesColors.CYAN
+
+    # Normal header colors (non-sorted columns)
+    normal_header_fg: int = CursesColors.WHITE
+    normal_header_bg: int = CursesColors.BLUE
 
     # Data row colors
     samples_fg: int = CursesColors.CYAN
@@ -303,7 +307,7 @@ class LiveProfiler(ThemeSection):
     # Status display colors
     pid_fg=CursesColors.BLUE,
     uptime_fg=CursesColors.GREEN,
-    time_fg=CursesColors.YELLOW,
+    time_fg=CursesColors.RED,  # Use red instead of yellow for better visibility on light bg
     interval_fg=CursesColors.MAGENTA,
 
     # Thread view colors
@@ -317,23 +321,27 @@ class LiveProfiler(ThemeSection):
     # Stats colors
     on_gil_fg=CursesColors.GREEN,
     off_gil_fg=CursesColors.RED,
-    waiting_gil_fg=CursesColors.YELLOW,
+    waiting_gil_fg=CursesColors.RED,  # Use red instead of yellow for visibility
     gc_fg=CursesColors.MAGENTA,
 
     # Function display colors
     func_total_fg=CursesColors.BLUE,
     func_exec_fg=CursesColors.GREEN,
-    func_stack_fg=CursesColors.YELLOW,
+    func_stack_fg=CursesColors.RED,  # Use red instead of yellow
     func_shown_fg=CursesColors.MAGENTA,
 
-    # Table header colors
+    # Table header colors (for sorted column highlight)
     sorted_header_fg=CursesColors.WHITE,
-    sorted_header_bg=CursesColors.BLUE,
+    sorted_header_bg=CursesColors.MAGENTA,
+
+    # Normal header colors (non-sorted columns)
+    normal_header_fg=CursesColors.WHITE,
+    normal_header_bg=CursesColors.BLUE,
 
     # Data row colors
     samples_fg=CursesColors.BLUE,
     file_fg=CursesColors.GREEN,
-    func_fg=CursesColors.MAGENTA,
+    func_fg=CursesColors.MAGENTA,  # Use magenta instead of yellow
 
     # Trend indicator colors
     trend_up_fg=CursesColors.GREEN,

Lib/profiling/sampling/live_collector/collector.py

@@ -540,8 +540,12 @@ def _setup_colors(self):
                 self.display.init_color_pair(2, profiler_theme.file_fg, default_bg)
                 self.display.init_color_pair(3, profiler_theme.func_fg, default_bg)
 
-                header_bg = 2 if profiler_theme.background_style == "dark" else 4
-                self.display.init_color_pair(COLOR_PAIR_HEADER_BG, 0, header_bg)
+                # Normal header background color pair
+                self.display.init_color_pair(
+                    COLOR_PAIR_HEADER_BG,
+                    profiler_theme.normal_header_fg,
+                    profiler_theme.normal_header_bg,
+                )
 
                 self.display.init_color_pair(COLOR_PAIR_CYAN, profiler_theme.pid_fg, default_bg)
                 self.display.init_color_pair(COLOR_PAIR_YELLOW, profiler_theme.time_fg, default_bg)
@@ -567,7 +571,7 @@ def _setup_colors(self):
                     "magenta": self.display.get_color_pair(COLOR_PAIR_MAGENTA) | A_BOLD,
                     "red": self.display.get_color_pair(COLOR_PAIR_RED) | A_BOLD,
                     "sorted_header": self.display.get_color_pair(COLOR_PAIR_SORTED_HEADER) | A_BOLD,
-                    "normal_header": A_REVERSE | A_BOLD,
+                    "normal_header": self.display.get_color_pair(COLOR_PAIR_HEADER_BG) | A_BOLD,
                     "color_samples": self.display.get_color_pair(1),
                     "color_file": self.display.get_color_pair(2),
                     "color_func": self.display.get_color_pair(3),
@@ -576,6 +580,7 @@ def _setup_colors(self):
                     "trend_stable": A_NORMAL,
                 }
 
+        # Fallback for no-color mode
         return {
             "header": A_REVERSE | A_BOLD,
             "cyan": A_BOLD,

Lib/profiling/sampling/live_collector/display.py

@@ -74,13 +74,17 @@ def get_dimensions(self):
         return self.stdscr.getmaxyx()
 
     def clear(self):
-        self.stdscr.clear()
+        # Use erase() instead of clear() to avoid flickering
+        # clear() forces a complete screen redraw, erase() just clears the buffer
+        self.stdscr.erase()
 
     def refresh(self):
         self.stdscr.refresh()
 
     def redraw(self):
-        self.stdscr.redrawwin()
+        # Use noutrefresh + doupdate for smoother updates
+        self.stdscr.noutrefresh()
+        curses.doupdate()
 
     def add_str(self, line, col, text, attr=0):
         try:

Lib/profiling/sampling/live_collector/widgets.py

@@ -729,8 +729,7 @@ def draw_stats_rows(self, line, height, width, stats_list, column_flags):
             column_flags
         )
 
-        # Get color attributes from the colors dict (already initialized)
-        color_samples = self.colors.get("color_samples", curses.A_NORMAL)
+        # Get color attributes
         color_file = self.colors.get("color_file", curses.A_NORMAL)
         color_func = self.colors.get("color_func", curses.A_NORMAL)
 
@@ -759,18 +758,18 @@ def draw_stats_rows(self, line, height, width, stats_list, column_flags):
                 else 0
             )
 
-            # Helper function to get trend color for a specific column
+            # Helper function to get trend color
             def get_trend_color(column_name):
                 trend = trends.get(column_name, "stable")
-                if trend_tracker is not None:
+                if trend_tracker is not None and trend_tracker.enabled:
                     return trend_tracker.get_color(trend)
                 return curses.A_NORMAL
 
             filename, lineno, funcname = func[0], func[1], func[2]
             samples_str = f"{direct_calls}/{cumulative_calls}"
             col = 0
 
-            # Samples column - apply trend color based on nsamples trend
+            # Samples column - apply trend color
             nsamples_color = get_trend_color("nsamples")
             self.add_str(line, col, f"{samples_str:>13}", nsamples_color)
             col += 15
@@ -819,9 +818,7 @@ def get_trend_color(column_name):
                     simplified_path = self.collector.simplify_path(filename)
                     file_line = f"{simplified_path}:{lineno}"
                     remaining_width = width - col - 1
-                    self.add_str(
-                        line, col, file_line[:remaining_width], color_file
-                    )
+                    self.add_str(line, col, file_line[:remaining_width], color_file)
 
             line += 1
 

Misc/NEWS.d/next/Library/2025-12-06-19-49-20.gh-issue-138122.m3EF9E.rst

@@ -1,4 +1,5 @@
 The Tachyon profiler's live TUI now integrates with the experimental
-:mod:`!_colorize` theming system, allowing users to customize colors via
-:func:`!_colorize.set_theme`. A :class:`!LiveProfilerLight` theme is provided
-for light terminal backgrounds. Patch by Pablo Galindo.
+:mod:`!_colorize` theming system. Users can customize colors via
+:func:`!_colorize.set_theme` (experimental API, subject to change).
+A :class:`!LiveProfilerLight` theme is provided for light terminal backgrounds.
+Patch by Pablo Galindo.