Updating event variables while the queue is locked

Author: prithviraj-chaudhuri

Modules/_interpqueuesmodule.c

@@ -646,8 +646,8 @@ _queue_add(_queue *queue, int64_t interpid, _PyXIData_t *data, int unboundop)
         maxsize = PY_SSIZE_T_MAX;
     }
     if (queue->items.count >= maxsize) {
-        _queue_unlock(queue);
         queue->space_available = (PyEvent){0};
+        _queue_unlock(queue);
         return ERR_QUEUE_FULL;
     }
 
@@ -666,8 +666,9 @@ _queue_add(_queue *queue, int64_t interpid, _PyXIData_t *data, int unboundop)
     }
     queue->items.last = item;
 
-    _queue_unlock(queue);
     queue->has_item = (PyEvent){1};
+
+    _queue_unlock(queue);
     return 0;
 }
 
@@ -682,8 +683,8 @@ _queue_next(_queue *queue, _PyXIData_t **p_data, int *p_unboundop)
     assert(queue->items.count >= 0);
     _queueitem *item = queue->items.first;
     if (item == NULL) {
-        _queue_unlock(queue);
         queue->has_item = (PyEvent){0};
+        _queue_unlock(queue);
         return ERR_QUEUE_EMPTY;
     }
     queue->items.first = item->next;