[cpp-libcurl] Fix Sonar issues with API keys

ppritchard-peer · ppritchard-peer · commit b04331cde0c8 · 2025-08-11T18:00:02.000+01:00
diff --git a/modules/openapi-generator/src/main/resources/cpp-libcurl/apiclient-source.mustache b/modules/openapi-generator/src/main/resources/cpp-libcurl/apiclient-source.mustache
@@ -315,8 +315,7 @@ ApiResponse ApiClient::callApi(
     {{#authMethods}}
     {{#isApiKey}}
     // this would only be generated for apiKey authentication
-    const auto &apiKeys = m_Configuration->getApiKeys();
-    if (apiKeys.size() > 0) {
+    if (const auto &apiKeys = m_Configuration->getApiKeys(); !apiKeys.empty()) {
         for (const auto &[key, value] : apiKeys) {
             std::string apiKey = key + ": " + value;
 
diff --git a/samples/client/petstore/cpp/libcurl/src/ApiClient.cpp b/samples/client/petstore/cpp/libcurl/src/ApiClient.cpp
@@ -320,8 +320,7 @@ ApiResponse ApiClient::callApi(
     }
 
     // this would only be generated for apiKey authentication
-    const auto &apiKeys = m_Configuration->getApiKeys();
-    if (apiKeys.size() > 0) {
+    if (const auto &apiKeys = m_Configuration->getApiKeys(); !apiKeys.empty()) {
         for (const auto &[key, value] : apiKeys) {
             std::string apiKey = key + ": " + value;
 

Original file line number	Diff line number	Diff line change
`@@ -320,8 +320,7 @@ ApiResponse ApiClient::callApi(`
`320`	`320`	`}`
`321`	`321`
`322`	`322`	`// this would only be generated for apiKey authentication`
`323`		`- const auto &apiKeys = m_Configuration->getApiKeys();`
`324`		`- if (apiKeys.size() > 0) {`
	`323`	`+ if (const auto &apiKeys = m_Configuration->getApiKeys(); !apiKeys.empty()) {`
`325`	`324`	`for (const auto &[key, value] : apiKeys) {`
`326`	`325`	`std::string apiKey = key + ": " + value;`
`327`	`326`