Skip to content

Commit a4a5a5b

Browse files
committed
fix: apply comments from copilot review
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
1 parent e9c84a6 commit a4a5a5b

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

README_WINDOWS.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ Microsoft Visual Studio C++ | Visual Studio 2019 (aka VS16) |
2020

2121
## Before building
2222

23-
The directory where you build software from source ( ``C:\work`` in this exmaple)
24-
must contain the Apache source you used to build the Apache web serverand the mod_security source
23+
The directory where you build software from source ( ``C:\work`` in this example)
24+
must contain the Apache source you used to build the Apache web server and the mod_security source
2525

26-
Apache source is in C:\work\httpd-2.4.27 in this example.
26+
Apache source is in C:\work\httpd-2.4.66 in this example.
2727
Apache has been installed to C:\Apache2466 in this example.
2828
Mod_security source is in C:\work\mod_security in this example.
2929

@@ -53,7 +53,7 @@ must contain the Apache source you used to build the Apache web serverand the mo
5353
3. Set an environment variable to the Apache source code directory:
5454

5555
```
56-
SET HTTPD_BUILD=C:\work\httpd-2.4.27
56+
SET HTTPD_BUILD=C:\work\httpd-2.4.66
5757
```
5858

5959
### Optional:
@@ -180,7 +180,7 @@ Create a new command file ``C:\Apache2466\bin\mlogc.bat`` with one line:
180180
Create a new configuration file ``C:\Apache2466\conf\mlogc.conf`` to control the piped-logging program ``mlogc.exe``.
181181
Here is an example ``conf\mlogc.conf``:
182182

183-
CollectorRoot "C:/Apache2427/logs"
183+
CollectorRoot "C:/Apache2466/logs"
184184
ConsoleURI "https://localhost:8888/rpc/auditLogReceiver"
185185
SensorUsername "test"
186186
SensorPassword "testtest"
@@ -200,4 +200,4 @@ Here is an example ``conf\mlogc.conf``:
200200

201201
Change the SecAuditLog directive in ``conf\httpd.conf`` to pipe the log data to mlogc instead of writing them to a file:
202202

203-
SecAuditLog |C:/Apache2427/bin/mlogc.bat
203+
SecAuditLog |C:/Apache2466/bin/mlogc.bat

iis/build_modsecurity.bat

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,21 @@ set CURRENT_DIR=%cd%
1515
cd ..\apache2
1616
del *.obj *.dll *.lib
1717
del libinjection\*.obj libinjection\*.dll libinjection\*.lib
18-
NMAKE -f Makefile.win APACHE=..\iis\%DEPENDENCIES_DIR%\Apache24 PCRE=..\iis\%DEPENDENCIES_DIR%\pcre LIBXML2=..\iis\%DEPENDENCIES_DIR%\libxml2 LUA=..\iis\%DEPENDENCIES_DIR%\lua\src VERSION=VERSION_IIS YAJL=..\iis\%DEPENDENCIES_DIR%\yajl\build\yajl-2.1.0 SSDEEP=..\iis\%DEPENDENCIES_DIR%\ssdeep CURL=..\iis\%DEPENDENCIES_DIR%\curl IIS_BUILD=yes
18+
NMAKE -f Makefile.win APACHE=..\iis\%DEPENDENCIES_DIR%\Apache24 PCRE=..\iis\%DEPENDENCIES_DIR%\pcre2 LIBXML2=..\iis\%DEPENDENCIES_DIR%\libxml2 LUA=..\iis\%DEPENDENCIES_DIR%\lua\src VERSION=VERSION_IIS YAJL=..\iis\%DEPENDENCIES_DIR%\yajl\build\yajl-2.1.0 SSDEEP=..\iis\%DEPENDENCIES_DIR%\ssdeep CURL=..\iis\%DEPENDENCIES_DIR%\curl IIS_BUILD=yes
1919
@if NOT (%ERRORLEVEL%) == (0) goto build_failed
2020

2121
@echo mlogc...
2222
cd ..\mlogc
2323
del *.obj *.dll *.lib
2424
nmake -f Makefile.win clean
25-
nmake -f Makefile.win APACHE=..\iis\%DEPENDENCIES_DIR%\Apache24 PCRE=..\iis\%DEPENDENCIES_DIR%\pcre CURL=..\iis\%DEPENDENCIES_DIR%\curl YAJL=..\iis\%DEPENDENCIES_DIR%\yajl\build\yajl-2.1.0 SSDEEP=..\iis\%DEPENDENCIES_DIR%\ssdeep VERSION=VERSION_IIS
25+
nmake -f Makefile.win APACHE=..\iis\%DEPENDENCIES_DIR%\Apache24 PCRE=..\iis\%DEPENDENCIES_DIR%\pcre2 CURL=..\iis\%DEPENDENCIES_DIR%\curl YAJL=..\iis\%DEPENDENCIES_DIR%\yajl\build\yajl-2.1.0 SSDEEP=..\iis\%DEPENDENCIES_DIR%\ssdeep VERSION=VERSION_IIS
2626
@if NOT (%ERRORLEVEL%) == (0) goto build_failed
2727

2828
@echo iis...
2929
cd ..\iis
3030
del *.obj *.dll *.lib
3131
nmake -f Makefile.win clean
32-
NMAKE -f Makefile.win APACHE=..\iis\%DEPENDENCIES_DIR%\Apache24 PCRE=..\iis\%DEPENDENCIES_DIR%\pcre LIBXML2=..\iis\%DEPENDENCIES_DIR%\libxml2 LUA=..\iis\%DEPENDENCIES_DIR%\lua\src VERSION=VERSION_IIS YAJL=..\iis\%DEPENDENCIES_DIR%\yajl\build\yajl-2.1.0 SSDEEP=..\iis\%DEPENDENCIES_DIR%\ssdeep CURL=..\iis\%DEPENDENCIES_DIR%\curl
32+
NMAKE -f Makefile.win APACHE=..\iis\%DEPENDENCIES_DIR%\Apache24 PCRE=..\iis\%DEPENDENCIES_DIR%\pcre2 LIBXML2=..\iis\%DEPENDENCIES_DIR%\libxml2 LUA=..\iis\%DEPENDENCIES_DIR%\lua\src VERSION=VERSION_IIS YAJL=..\iis\%DEPENDENCIES_DIR%\yajl\build\yajl-2.1.0 SSDEEP=..\iis\%DEPENDENCIES_DIR%\ssdeep CURL=..\iis\%DEPENDENCIES_DIR%\curl
3333
@if NOT (%ERRORLEVEL%) == (0) goto build_failed
3434

3535
cd %CURRENT_DIR%

0 commit comments

Comments
 (0)