ListIterator: listIterator() shall check the index bounds

Author: greenrobot

objectbox-java/src/main/java/io/objectbox/query/LazyList.java

@@ -278,6 +278,9 @@ public ListIterator<E> listIterator() {
 
     @Override
     public ListIterator<E> listIterator(int location) {
+        if (location < 0 || location > size) {
+            throw new IndexOutOfBoundsException("Index: " + location + ", Size: " + size);
+        }
         return new LazyIterator(location);
     }
 

tests/objectbox-java-test/src/test/java/io/objectbox/query/LazyListTest.java

@@ -176,6 +176,29 @@ public void testUncached() {
         }
     }
 
+    @Test
+    public void listIterator_indexOutOfBounds_throws() {
+        putTestEntities(3);
+        LazyList<TestEntity> listLazy = getTestEntityBox().query().build().findLazyCached();
+        int size = listLazy.size();
+
+        try {
+            listLazy.listIterator(-1);
+            fail("listIterator should throw for negative index");
+        } catch (IndexOutOfBoundsException expected) {
+            // Expected, OK
+        }
+
+        try {
+            listLazy.listIterator(size + 1);
+            fail("listIterator should throw for index larger than size");
+        } catch (IndexOutOfBoundsException expected) {
+            // Expected, OK
+        }
+
+        assertNotNull(listLazy.listIterator(size));
+    }
+
 
     protected void assertIds(List<TestEntity> list, List<TestEntity> list2) {
         for (int i = 0; i < list.size(); i++) {