Skip to content

Commit 8f5edd7

Browse files
Sync client: improve explanation of apply variable mechanism
1 parent af79ef5 commit 8f5edd7

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

objectbox-java/src/main/java/io/objectbox/sync/SyncClient.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,28 +142,26 @@ public interface SyncClient extends Closeable {
142142
* Adds or replaces a <a href="https://sync.objectbox.io/sync-server/sync-filters">Sync filter</a> variable value
143143
* for the given name.
144144
* <p>
145+
* Note: If the client is already logged in, this change is not applied until {@link #applyFilterVariables()} is
146+
* called. This allows to put or remove multiple variables before applying all changes. Filter variables set before
147+
* login (before calling {@link #start()}) are automatically applied.
148+
* <p>
145149
* Eventually, existing values for the same name are replaced.
146150
* <p>
147151
* Sync client filter variables can be used in server-side Sync filters to filter out objects that do not match the
148152
* filter.
149-
* <p>
150-
* Filter variables can be set in two states:
151-
* <ol>
152-
* <li>Before login (e.g. before calling {@link #start()} or setting credentials): no
153-
* {@link #applyFilterVariables()} call required.</li>
154-
* <li>After login: updates are staged as "pending" until {@link #applyFilterVariables()} is called.</li>
155-
* </ol>
156153
*
157154
* @see #removeFilterVariable
158155
* @see #removeAllFilterVariables
159-
* @see #applyFilterVariables()
156+
* @see #applyFilterVariables
160157
*/
161158
void putFilterVariable(String name, String value);
162159

163160
/**
164161
* Removes a previously added Sync filter variable value.
165162
* <p>
166-
* If used after login, see {@link #putFilterVariable} for notes about {@link #applyFilterVariables}.
163+
* Note: If the client is already logged in, this change is not applied until {@link #applyFilterVariables()} is
164+
* called. See {@link #putFilterVariable} for details.
167165
*
168166
* @see #putFilterVariable
169167
* @see #removeAllFilterVariables
@@ -173,7 +171,8 @@ public interface SyncClient extends Closeable {
173171
/**
174172
* Removes all previously added Sync filter variable values.
175173
* <p>
176-
* If used after login, see {@link #putFilterVariable} for notes about {@link #applyFilterVariables}.
174+
* Note: If the client is already logged in, this change is not applied until {@link #applyFilterVariables()} is
175+
* called. See {@link #putFilterVariable} for details.
177176
*
178177
* @see #putFilterVariable
179178
* @see #removeFilterVariable

0 commit comments

Comments
 (0)