return 404 when no matching route is found (#1067)

* return 404 when a matching route is not found

* update other middleware and tests

Author: sonu27

oapi_validate.go

@@ -119,7 +119,7 @@ func ValidateRequestFromContext(ctx echo.Context, router routers.Router, options
 		case *routers.RouteError:
 			// We've got a bad request, the path requested doesn't match
 			// either server, or path, or something.
-			return echo.NewHTTPError(http.StatusBadRequest, e.Reason)
+			return echo.NewHTTPError(http.StatusNotFound, e.Reason)
 		default:
 			// This should never happen today, but if our upstream code changes,
 			// we don't want to crash the server, so handle the unexpected error.

oapi_validate_test.go

@@ -102,10 +102,10 @@ func TestOapiRequestValidator(t *testing.T) {
 		called = true
 		return nil
 	})
-	// Let's send the request to the wrong server, this should fail validation
+	// Let's send the request to the wrong server, this should return 404
 	{
 		rec := doGet(t, e, "http://not.deepmap.ai/resource")
-		assert.Equal(t, http.StatusBadRequest, rec.Code)
+		assert.Equal(t, http.StatusNotFound, rec.Code)
 		assert.False(t, called, "Handler should not have been called")
 	}