fix(api): address code review suggestions (#66)

- Add -> List[Player] return type to retrieve_all_async (List imported)
- Add None guard to update_async to prevent AttributeError on missing player
- Move PRAGMA calls inside try block in seed_001 so conn.close() always runs
- Remove duplicate client.delete() call in DELETE test (caused 404 assertion)
- Re-seed storage/players-sqlite3.db with hyphenated UUIDs (previous commit
  stored UUIDs without hyphens, breaking HyphenatedUUID lookups)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: nanotaboada

services/player_service.py

@@ -15,7 +15,7 @@
 """
 
 import logging
-from typing import Optional
+from typing import List, Optional
 from uuid import UUID
 
 from sqlalchemy import select
@@ -61,7 +61,7 @@ async def create_async(
 # Retrieve ---------------------------------------------------------------------
 
 
-async def retrieve_all_async(async_session: AsyncSession):
+async def retrieve_all_async(async_session: AsyncSession) -> List[Player]:
     """
     Retrieves all the players from the database.
 
@@ -133,6 +133,9 @@ async def update_async(
         True if the Player was updated successfully, False otherwise.
     """
     player = await async_session.get(Player, player_id)
+    if player is None:  # pragma: no cover
+        logger.error("Player not found for update: %s", player_id)
+        return False
     player.first_name = player_model.first_name
     player.middle_name = player_model.middle_name
     player.last_name = player_model.last_name

storage/players-sqlite3.db

@@ -18,7 +18,11 @@
 
 from uuid import UUID
 
-from tests.player_stub import existing_player, nonexistent_player, unknown_player
+from tests.player_stub import (
+    existing_player,
+    nonexistent_player,
+    unknown_player,
+)
 
 PATH = "/players/"
 

tests/test_main.py

@@ -249,10 +249,11 @@ def run(db_path: Path) -> None:
         sys.exit(1)
 
     conn = sqlite3.connect(db_path)
-    conn.execute("PRAGMA journal_mode=WAL")
-    conn.execute("PRAGMA foreign_keys=ON")
 
     try:
+        conn.execute("PRAGMA journal_mode=WAL")
+        conn.execute("PRAGMA foreign_keys=ON")
+
         id_type = _id_column_type(conn)
 
         if id_type == "TEXT" and _already_migrated(conn):