From 48c10324b9d9fe0c940e15e2799fae261f52b30e Mon Sep 17 00:00:00 2001 From: Nano Taboada <87288+nanotaboada@users.noreply.github.com> Date: Sun, 29 Mar 2026 13:34:43 -0300 Subject: [PATCH 1/2] chore(github): update issue templates and add PR template Co-Authored-By: Claude Sonnet 4.6 --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- .github/ISSUE_TEMPLATE/config.yml | 1 + .github/ISSUE_TEMPLATE/feature_request.md | 12 ++++++------ .github/pull_request_template.md | 21 +++++++++++++++++++++ 4 files changed, 29 insertions(+), 7 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/config.yml create mode 100644 .github/pull_request_template.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 4b732f6..20dac30 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,7 +1,7 @@ --- name: Bug report about: Report a bug or unexpected behavior -title: "[BUG]" +title: '' labels: bug, .NET assignees: '' diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 0000000..3ba13e0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1 @@ +blank_issues_enabled: false diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index c823bb8..217c561 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -1,7 +1,7 @@ --- name: Feature request about: Propose a new feature or enhancement -title: "[FEATURE]" +title: '' labels: enhancement, .NET assignees: '' @@ -15,17 +15,17 @@ What problem are you trying to solve? What's the pain point? Describe the expected behavior and functionality this feature will provide. -## Suggested Approach +## Suggested Approach _(optional)_ -Describe the technical implementation plan. Include architecture, key files/modules to modify, APIs, and any code patterns to follow. +If known, describe the technical implementation plan. Include architecture, key files/modules to modify, APIs, and any code patterns to follow. ## Acceptance Criteria How will we know this feature is complete and working correctly? -- [ ] Criterion 1 -- [ ] Criterion 2 -- [ ] Criterion 3 +- [ ] Feature behaves as described in the proposed solution +- [ ] Tests are added or updated to cover the new functionality +- [ ] No regressions in existing tests ## References diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000..8413d12 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,21 @@ +## Summary + +Brief description of the changes and why they were made. + +## Type of Change + +- [ ] `feat` — new feature +- [ ] `fix` — bug fix +- [ ] `chore` — maintenance, tooling, or dependency update +- [ ] `docs` — documentation only +- [ ] `test` — adding or updating tests +- [ ] `refactor` — code change that neither fixes a bug nor adds a feature +- [ ] `ci` — CI/CD changes +- [ ] `perf` — performance improvement + +## Checklist + +- [ ] `CHANGELOG.md` updated +- [ ] All tests pass +- [ ] No regressions introduced +- [ ] Follows project coding guidelines From a9e5ab8444ef55aee3e6f2e97b32266e239a2597 Mon Sep 17 00:00:00 2001 From: Nano Taboada <87288+nanotaboada@users.noreply.github.com> Date: Sun, 29 Mar 2026 13:39:53 -0300 Subject: [PATCH 2/2] chore(github): document SDD workflow and issue templates in instructions Co-Authored-By: Claude Sonnet 4.6 --- .github/copilot-instructions.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 59fae9e..9a4225f 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -183,6 +183,25 @@ Example: `feat(api): add player search endpoint (#123)` - Database type (SQLite — demo/dev only) - CD pipeline tag format (`vX.Y.Z-stadium`) or the stadium name sequence — names are assigned sequentially A→Z from the list in `CHANGELOG.md`; the next name is always the next unused letter +### Creating Issues + +This project uses Spec-Driven Development (SDD): discuss in Plan mode first, create a GitHub Issue as the spec artifact, then implement. Always offer to draft an issue before writing code. + +**Feature request** (`enhancement` label): +- **Problem**: the pain point being solved +- **Proposed Solution**: expected behavior and functionality +- **Suggested Approach** *(optional)*: implementation plan if known +- **Acceptance Criteria**: at minimum — behaves as proposed, tests added/updated, no regressions +- **References**: related issues, docs, or examples + +**Bug report** (`bug` label): +- **Description**: clear summary of the bug +- **Steps to Reproduce**: numbered, minimal steps +- **Expected / Actual Behavior**: one section each +- **Environment**: runtime versions + OS +- **Additional Context**: logs, screenshots, stack traces +- **Possible Solution** *(optional)*: suggested fix or workaround + ### Key workflows **Add an endpoint**: Add DTO in `Models/` → update `PlayerMappingProfile` in `Mappings/` → add repository method(s) in `Repositories/` → add service method in `Services/` → add controller action in `Controllers/` → add/update validator rule set in `Validators/` → add tests in `test/.../Unit/` → run pre-commit checks.