Skip to content

Commit 24996e7

Browse files
nanotaboadaclaude
andcommitted
chore(claude): address pre-commit and pre-release review feedback (#440)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent f15a75e commit 24996e7

2 files changed

Lines changed: 17 additions & 9 deletions

File tree

.claude/commands/pre-commit.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ Run the pre-commit checklist for this project:
99
- If only nitpick-level findings, report them and continue to the commit proposal.
1010
- If `coderabbit` is not installed, skip this step with a note.
1111

12-
Run steps 1–4, report the results clearly, run step 5 if available, then propose a branch name and commit message for my approval using the format `type(scope): description (#issue)` (max 80 chars; types: `feat` `fix` `chore` `docs` `test` `refactor` `ci` `perf`). Do not create the branch or commit until I explicitly confirm.
12+
Run steps 1–4, report the results clearly, then run step 5 (CodeRabbit review) if available, then propose a branch name and commit message for my approval using the format `type(scope): description (#issue)` (max 80 chars; types: `feat` `fix` `chore` `docs` `test` `refactor` `ci` `perf`). Do not create the branch or commit until I explicitly confirm.

.claude/commands/pre-release.md

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,19 @@ proceeding. Never create a branch, commit, tag, or push without approval.
1212
2. Run `git tag --sort=-v:refname` to list existing tags. Identify the most
1313
recent tag matching `v*.*.*-*` and extract its stadium codename.
1414

15-
3. Read the A–Z stadium table from `CHANGELOG.md` to find the stadium that
16-
follows the last used codename alphabetically. That is the next stadium.
15+
3. Read the A–Z stadium table from `CHANGELOG.md` to find the next stadium:
16+
- **No tags yet**: start at `A` (first stadium in the table).
17+
- **Normal case**: use the stadium that follows the last used codename
18+
alphabetically. If letters were skipped, pick the next after the
19+
highest existing codename — do not backfill gaps.
20+
- **Last codename is `Z`** (Zentralstadion): the list is finite. Stop and
21+
refer to ADR 0012 for guidance on extending or revisiting the convention.
1722

1823
4. Read the `[Unreleased]` section of `CHANGELOG.md` and infer the version
1924
bump using these rules (applied in order — first match wins):
20-
- Any entry contains the word **BREAKING****major** bump
25+
- Any entry contains the word **BREAKING** (case-insensitive), a
26+
`BREAKING CHANGE:` token in a commit footer, or a `!` suffix after
27+
the commit type/scope (e.g. `feat!:` or `feat(scope)!:`) → **major** bump
2128
- Any `### Added` subsection has entries → **minor** bump
2229
- Otherwise (only `### Changed`, `### Fixed`, `### Removed`) → **patch** bump
2330

@@ -53,15 +60,16 @@ proceeding. Never create a branch, commit, tag, or push without approval.
5360

5461
3. Show the full diff of `CHANGELOG.md` and propose this commit message:
5562

56-
```
63+
```text
5764
docs(changelog): prepare release notes for vX.Y.Z-{stadium} (#issue)
5865
```
5966

6067
**Wait for explicit approval before committing.**
6168

62-
4. Run `/pre-commit`, skipping step 1 — CHANGELOG was already updated above.
63-
Open with: "Skip step 1 — CHANGELOG was already updated as part of this
64-
release branch."
69+
4. Run `/pre-commit`, manually skipping step 1 — do not re-run or re-attempt
70+
the CHANGELOG update; it was already completed above. Open with: "Skip
71+
step 1 — CHANGELOG was already updated as part of this release branch."
72+
Proceed directly with steps 2–5.
6573

6674
5. Propose opening a PR from `release/vX.Y.Z-{stadium}` into `master`.
6775
**Wait for explicit approval before opening.**
@@ -86,7 +94,7 @@ proceeding. Never create a branch, commit, tag, or push without approval.
8694

8795
3. Propose the annotated tag:
8896
```bash
89-
git tag -a vX.Y.Z-{stadium} -m "Release vX.Y.Z - StadiumName"
97+
git tag -a vX.Y.Z-{stadium} -m "Release X.Y.Z - StadiumName"
9098
```
9199

92100
**Wait for explicit approval before creating the tag.**

0 commit comments

Comments
 (0)