Merge pull request #335 from msgpack/test-static-insert

Use a runtime assert during init instead of _Static_assert

Author: byroot

.github/workflows/ci.yaml

@@ -33,6 +33,8 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true # 'bundle install' and cache
       - run: bundle exec rake
+        env:
+          MSGPACK_DEBUG: "true"
 
   valgrind:
     runs-on: ubuntu-latest
@@ -59,6 +61,8 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true # 'bundle install' and cache
       - run: bundle exec rake spec
+        env:
+          MSGPACK_DEBUG: "true"
 
   head-versions:
     continue-on-error: true
@@ -75,3 +79,5 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true # 'bundle install' and cache
       - run: bundle exec rake spec || echo "failed, but ignore it"
+        env:
+          MSGPACK_DEBUG: "true"

ext/msgpack/extconf.rb

@@ -14,6 +14,8 @@
 ])
 append_cflags(RbConfig::CONFIG["debugflags"]) if RbConfig::CONFIG["debugflags"]
 
+append_cflags("-DRUBY_DEBUG=1") if ENV["MSGPACK_DEBUG"]
+
 if RUBY_VERSION.start_with?('3.0.') && RUBY_VERSION <= '3.0.5'
   # https://bugs.ruby-lang.org/issues/18772
   append_cflags("-DRB_ENC_INTERNED_STR_NULL_CHECK=1")

ext/msgpack/unpacker.c

@@ -19,11 +19,7 @@
 #include "unpacker.h"
 #include "rmem.h"
 #include "extension_value_class.h"
-
-_Static_assert(
-    sizeof(msgpack_unpacker_stack_entry_t) * MSGPACK_UNPACKER_STACK_CAPACITY <= MSGPACK_RMEM_PAGE_SIZE,
-    "msgpack_unpacker_stack_entry_t is too big to fit MSGPACK_UNPACKER_STACK_CAPACITY in MSGPACK_RMEM_PAGE_SIZE"
-);
+#include <assert.h>
 
 static int RAW_TYPE_STRING = 256;
 static int RAW_TYPE_BINARY = 257;
@@ -41,6 +37,8 @@ static inline VALUE rb_hash_new_capa(long capa)
 
 void msgpack_unpacker_static_init(void)
 {
+    assert(sizeof(msgpack_unpacker_stack_entry_t) * MSGPACK_UNPACKER_STACK_CAPACITY <= MSGPACK_RMEM_PAGE_SIZE);
+
     msgpack_rmem_init(&s_stack_rmem);
 
     s_call = rb_intern("call");