chore: nbdev v3

Author: moneebullah25

.claude/rules/tooling.md

@@ -75,7 +75,7 @@ alwaysApply: true
 - The hook runs `.claude/validate.sh` with a 300-second timeout and `asyncRewake: true`.
 - Conditional logic in `validate.sh`:
   - **Skips entirely** for non-source files (`.md`, `.json`, `.yaml`, `.yml`, `.toml`, `.txt`, `.sh`, `.env`, `.gitignore`, `.dockerignore`).
-  - **For `.ipynb` files**: runs `nbdev_export` first, then `make lint` and `make test`.
+  - **For `.ipynb` files**: runs `nbdev-clean` (strip outputs), then `nbdev-export` (sync Python), warns if notebooks still have uncommitted changes, then `make lint` and `make nbdev-test`. This mirrors exactly what CI checks.
   - **For `.py` files**: always runs `make lint` and `make test`.
 - Exit code 2 on failure wakes the model to address the issue.
 

.claude/validate.sh

@@ -41,13 +41,25 @@ run() {
     fi
 }
 
-# For notebook changes, export first
+# For notebook changes: clean (strip outputs) then export (sync Python files).
+# Mirrors exactly what CI does: nbdev-clean must be a no-op on committed notebooks,
+# and nbdev-export must produce no diff vs committed Python files.
 if echo "$CHANGED_FILE" | grep -qE "\.ipynb$"; then
-    echo "--- nbdev_export ---"
+    echo "--- uv run nbdev-clean ---"
+    if ! uv run nbdev-clean; then
+        echo "FAILED: nbdev-clean"
+        FAILED=1
+    fi
+    echo "--- uv run nbdev-export ---"
     if ! uv run nbdev-export; then
-        echo "FAILED: nbdev_export"
+        echo "FAILED: nbdev-export"
         FAILED=1
     fi
+    # Warn if notebooks still differ after clean (outputs were not stripped before save)
+    DIRTY_NBS=$(git diff --name-only -- "*.ipynb" 2>/dev/null || true)
+    if [ -n "$DIRTY_NBS" ]; then
+        echo "WARNING: notebooks have uncommitted changes after nbdev-clean — commit them before pushing or CI will fail"
+    fi
 fi
 
 # Always run lint and notebook tests

nbs/01_deck.ipynb

@@ -284,7 +284,7 @@
     "#| export\n",
     "def draw_n(n:int, # number of cards to draw\n",
     "           replace:bool=True): # whether or not draw with replacement\n",
-    "    \"Draw `n` cards, with replacement iif `replace`\"\n",
+    "    \"Draw `n` cards, with replacement iff `replace`\"\n",
     "    d = Deck()\n",
     "    d.shuffle()\n",
     "    if replace: return [d.cards[random.choice(range(len(d.cards)))] for _ in range(n)]\n",
@@ -330,4 +330,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 5
-}
+}

nbs/index.ipynb

@@ -135,4 +135,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 5
-}
+}

pyproject.toml

@@ -98,7 +98,7 @@ ignore = ["E501", "E402", "E731", "W191", "COM812", "ISC002"]
 
 [tool.ruff.lint.per-file-ignores]
 # nbdev-generated files use fastcore star imports and @patch patterns
-"python_nbdev_starter/*.py" = ["F403", "F405", "E701", "E302", "E303"]
+"python_nbdev_starter/*.py" = ["F403", "F405", "E701", "E302", "E303", "I001"]
 
 
 # ---- Basedpyright ----

python_nbdev_starter/deck.py

@@ -40,7 +40,7 @@ def remove(self:Deck,
 # %% ../nbs/01_deck.ipynb #c06f233e
 def draw_n(n:int, # number of cards to draw
            replace:bool=True): # whether or not draw with replacement
-    "Draw `n` cards, with replacement iif `replace`"
+    "Draw `n` cards, with replacement iff `replace`"
     d = Deck()
     d.shuffle()
     if replace: return [d.cards[random.choice(range(len(d.cards)))] for _ in range(n)]