Capture Perfetto Trace Processor output to UI logger, so that is can be viewed inline as diagnostics w/o dissapearing. Also hide the window popup for a more seamless UI expereince. (#47)

Author: ivberg

PerfettoCds/Pipeline/PerfettoSourceParser.cs

@@ -10,6 +10,7 @@
 using PerfettoCds.Pipeline.Events;
 using System.IO;
 using System.Reflection;
+using System.Diagnostics;
 
 namespace PerfettoCds
 {
@@ -86,8 +87,12 @@ public void ProcessSource(ISourceDataProcessor<PerfettoSqlEventKeyed, PerfettoSo
                 var shellDir = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
                 var shellPath = Path.Combine(shellDir, PerfettoPluginConstants.TraceProcessorShellFileName);
 
+                // TraceProcessor seems to incorrectly output via stderr and not stdout (so we won't label stderr as Error)
+                DataReceivedEventHandler outputDataReceivedHandler = (sender, args) => logger.Verbose($"{PerfettoPluginConstants.TraceProcessorShellFileName}: {args.Data}");
+                DataReceivedEventHandler errorDataReceivedHandler  = (sender, args) => logger.Verbose($"{PerfettoPluginConstants.TraceProcessorShellFileName}: {args.Data}");
+
                 // Start the Perfetto trace processor shell with the trace file
-                traceProc.OpenTraceProcessor(shellPath, filePath);
+                traceProc.OpenTraceProcessor(shellPath, filePath, outputDataReceivedHandler, errorDataReceivedHandler);
 
                 // Use this callback to receive events parsed and turn them in events with keys
                 // that get used by data cookers
@@ -188,7 +193,7 @@ void EventCallback(PerfettoSqlEvent ev)
                     traceProc.QueryTraceForEvents(query.GetSqlQuery(), query.GetEventKey(), EventCallback);
                     var dateTimeQueryFinished = DateTime.UtcNow;
 
-                    logger.Verbose($"Query for {query.GetEventKey()} completed in {(dateTimeQueryFinished - dateTimeQueryStarted).TotalSeconds}s at {dateTimeQueryFinished} UTC");
+                    logger.Verbose($"Query for {query.GetEventKey()} completed in {(dateTimeQueryFinished - dateTimeQueryStarted).TotalSeconds}s at {dateTimeQueryFinished.ToString("MM/dd/yyyy HH:mm:ss.fff")} UTC");
 
                     IncreaseProgress(queryProgressIncrease);
 

PerfettoProcessor/PerfettoTraceProcessor.cs

@@ -95,29 +95,26 @@ private bool IsPortAvailable(int port)
         /// </summary>
         /// <param name="shellPath">Full path to trace_processor_shell.exe</param>
         /// <param name="tracePath">Full path to the Perfetto trace file</param>
-        public void OpenTraceProcessor(string shellPath, string tracePath)
+        public void OpenTraceProcessor(string shellPath, string tracePath, DataReceivedEventHandler outputDataReceivedEventHandler, DataReceivedEventHandler errorDataReceivedEventHandler)
         {
-            using (var client = new HttpClient())
-            {
-                // Make sure another instance of trace_processor_shell isn't already running
-                while (!IsPortAvailable(HttpPort) && HttpPort < PortMax)
-                {
-                    HttpPort++;
-                }
-
-                ShellProcess = Process.Start(shellPath, $"-D --http-port {HttpPort} -i \"{tracePath}\"");
-            }
-            if (ShellProcess.HasExited)
-            {
-                throw new Exception("Problem starting trace_processor_shell.exe");
-            }
+            StartTraceProcessor(shellPath, $"-D --http-port {HttpPort} -i \"{tracePath}\"", outputDataReceivedEventHandler, errorDataReceivedEventHandler);
         }
 
         /// <summary>
         /// Initializes trace_processor_shell.exe in HTTP/RPC mode without the trace file
         /// </summary>
         /// <param name="shellPath">Full path to trace_processor_shell.exe</param>
-        public void OpenTraceProcessor(string shellPath)
+        public void OpenTraceProcessor(string shellPath, DataReceivedEventHandler outputDataReceivedEventHandler, DataReceivedEventHandler errorDataReceivedEventHandler)
+        {
+            StartTraceProcessor(shellPath, $"-D --http-port {HttpPort}", outputDataReceivedEventHandler, errorDataReceivedEventHandler);
+        }
+
+        /// <summary>
+        /// Launches trace_processor_shell.exe
+        /// </summary>
+        /// <param name="shellPath">Full path to trace_processor_shell.exe</param>
+        /// <param name="args"></param>
+        private void StartTraceProcessor(string shellPath, string args, DataReceivedEventHandler outputDataReceivedEventHandler, DataReceivedEventHandler errorDataReceivedEventHandler)
         {
             using (var client = new HttpClient())
             {
@@ -126,7 +123,38 @@ public void OpenTraceProcessor(string shellPath)
                 {
                     HttpPort++;
                 }
-                ShellProcess = Process.Start(shellPath, $"-D --http-port {HttpPort}");
+
+                var traceProcessorProcessStartInfo = new ProcessStartInfo()
+                {
+                    FileName = shellPath,
+                    Arguments = args,
+                    RedirectStandardOutput = true,
+                    RedirectStandardError = true,
+                    CreateNoWindow = true,
+                };
+
+                ShellProcess = new Process();
+                ShellProcess.StartInfo = traceProcessorProcessStartInfo;
+
+                if (outputDataReceivedEventHandler != null)
+                {
+                    ShellProcess.OutputDataReceived += outputDataReceivedEventHandler;
+                }
+                if (errorDataReceivedEventHandler != null)
+                {
+                    ShellProcess.ErrorDataReceived += errorDataReceivedEventHandler;
+                }
+
+                ShellProcess.Start();
+
+                if (outputDataReceivedEventHandler != null)
+                {
+                    ShellProcess.BeginOutputReadLine();
+                }
+                if (errorDataReceivedEventHandler != null)
+                {
+                    ShellProcess.BeginErrorReadLine();
+                }
             }
             if (ShellProcess.HasExited)
             {
@@ -317,6 +345,8 @@ public void QueryTraceForEvents(string sqlQuery, string eventKey, Action<Perfett
 
         public void CloseTraceConnection()
         {
+            ShellProcess.CancelOutputRead();
+            ShellProcess.CancelErrorRead();
             ShellProcess?.Kill();
         }
     }