Use GitStrArray

jairbubbles · jairbubbles · commit 7f21164d5699 · 2021-11-22T11:14:26.000+01:00
diff --git a/LibGit2Sharp/Core/NativeMethods.cs b/LibGit2Sharp/Core/NativeMethods.cs
@@ -757,7 +757,7 @@ internal static extern int git_libgit2_opts(int option,
 
         // git_libgit2_opts(GIT_OPT_SET_EXTENSIONS, const char **extensions, size_t len)
         [DllImport(libgit2, CallingConvention = CallingConvention.Cdecl)]
-        internal static extern int git_libgit2_opts(int option, string[] extensions, int len);
+        internal static extern int git_libgit2_opts(int option, GitStrArray extensions);
 
         // git_libgit2_opts(GIT_OPT_GET_EXTENSIONS, git_strarray *out)
         [DllImport(libgit2, CallingConvention = CallingConvention.Cdecl)]
diff --git a/LibGit2Sharp/Core/Proxy.cs b/LibGit2Sharp/Core/Proxy.cs
@@ -3503,8 +3503,11 @@ public static string git_libgit2_opts_get_user_agent()
 
         public static void git_libgit2_opts_set_extensions(string[] extensions)
         {
-            var res = NativeMethods.git_libgit2_opts((int)LibGit2Option.SetExtensions, extensions, extensions.Length);
-            Ensure.ZeroResult(res);
+            using(var array = GitStrArrayManaged.BuildFrom(extensions))
+            {
+                var res = NativeMethods.git_libgit2_opts((int)LibGit2Option.SetExtensions, array.Array);
+                Ensure.ZeroResult(res);
+            }
         }
 
         public static string[] git_libgit2_opts_get_extensions()

Original file line number	Diff line number	Diff line change
`@@ -3503,8 +3503,11 @@ public static string git_libgit2_opts_get_user_agent()`
`3503`	`3503`
`3504`	`3504`	`public static void git_libgit2_opts_set_extensions(string[] extensions)`
`3505`	`3505`	`{`
`3506`		`- var res = NativeMethods.git_libgit2_opts((int)LibGit2Option.SetExtensions, extensions, extensions.Length);`
`3507`		`- Ensure.ZeroResult(res);`
	`3506`	`+ using(var array = GitStrArrayManaged.BuildFrom(extensions))`
	`3507`	`+ {`
	`3508`	`+ var res = NativeMethods.git_libgit2_opts((int)LibGit2Option.SetExtensions, array.Array);`
	`3509`	`+ Ensure.ZeroResult(res);`
	`3510`	`+ }`
`3508`	`3511`	`}`
`3509`	`3512`
`3510`	`3513`	`public static string[] git_libgit2_opts_get_extensions()`