Feat(unittest): unittests for adding duplicate itineraries finished, and passed after adding duplication checks in manage_itineraries.py

Author: xInsanityInRed

Travel_Itinerary_Planner/src/manage_itineraries.py

@@ -44,11 +44,16 @@ def add_itinerary(itinerary_list, name, location, description, start_date, end_d
         # print(new_itinerary)
         if itinerary_list:
             for itinerary in itinerary_list:
-                if new_itinerary== itinerary:
+                if new_itinerary == itinerary:
                     print("This itinerary already exists!\nReturning to main menu...")
                     return False
+                elif new_itinerary["name"] == itinerary["name"]:
+                    print(f"'{new_itinerary["name"]}' already exists!\nReturning to main menu...")
+                    return False
                 else:
                     itinerary_list.append(new_itinerary)
+        else:
+            itinerary_list.append(new_itinerary)
         # Uncomment to print for itinerary_list validation:
         # print(itinerary_list)
 

Travel_Itinerary_Planner/tests/test_manage_itineraries.py

@@ -48,7 +48,7 @@ def test_add_itinerary(self):
         Test adding a new task to the task list.
         Verify that the task is successfully added and the list size increases.
         """
-        test_itinerary = [{
+        test_itinerary = {
             "name": "trip", "location": "Japan", "description": "description", "start_date": "12-12-2026", "end_date": "28-01-2027", "flights": [{
                 "flight name": "Perth to Narita",
                 "departure airport": "Perth",
@@ -76,7 +76,7 @@ def test_add_itinerary(self):
                     "summary": "A lovely dinner spot",
                     "tag(s)": "dinner, romantic"
                 }
-            ]}]
+            ]}
 
         result = add_itinerary(self.itineraries, name=test_itinerary["name"], location=test_itinerary["location"], description=test_itinerary["description"], start_date=test_itinerary["start_date"], end_date=test_itinerary["end_date"], flights=test_itinerary["flights"], attractions=test_itinerary["attractions"])
 
@@ -86,10 +86,10 @@ def test_add_itinerary(self):
 
     def test_add_duplicate_itinerary(self):
         """
-        Test adding a duplicate task with the same title.
-        Verify that duplicates are not allowed and the function returns False.
+        Test adding a duplicate itinerary with the same title but different values, then a complete copy of the itinerary.
+        Verify that these itineraries are not allowed and the function returns False.
         """
-        test_itinerary = [{
+        test_itinerary = {
             "name": "trip", "location": "Japan", "description": "description", "start_date": "12-12-2026", "end_date": "28-01-2027", "flights": [{
                 "flight name": "Perth to Narita",
                 "departure airport": "Perth",
@@ -117,11 +117,16 @@ def test_add_duplicate_itinerary(self):
                     "summary": "A lovely dinner spot",
                     "tag(s)": "dinner, romantic"
                 }
-            ]}]
+            ]}
 
-        add_itinerary(self.itineraries, "Test Task", "Description", "01-12-2021", "Pending")
-        result = add_itinerary(self.itineraries, "Test Task", "New Description", "02-12-2024", "Pending")
-        self.assertFalse(result)
+        add_itinerary(self.itineraries, name=test_itinerary["name"], location=test_itinerary["location"], description=test_itinerary["description"], start_date=test_itinerary["start_date"], end_date=test_itinerary["end_date"], flights=test_itinerary["flights"], attractions=test_itinerary["attractions"])
+
+        same_name_result = add_itinerary(self.itineraries, name=test_itinerary["name"], location="Another location", description="Another description", start_date=test_itinerary["start_date"], end_date=test_itinerary["end_date"], flights=test_itinerary["flights"], attractions=test_itinerary["attractions"])
+
+        duplicate_result = add_itinerary(self.itineraries, name=test_itinerary["name"], location=test_itinerary["location"], description=test_itinerary["description"], start_date=test_itinerary["start_date"], end_date=test_itinerary["end_date"], flights=test_itinerary["flights"], attractions=test_itinerary["attractions"])
+
+        self.assertFalse(same_name_result)
+        self.assertFalse(duplicate_result)
 
     def test_add_invalid_itinerary(self):
         """