Fixes issue #376 and #379

Author: risenW

src/danfojs-base/shared/utils.ts

@@ -334,7 +334,8 @@ export default class Utils {
         if (
             typeof arr[0] == "number" ||
             typeof arr[0] == "string" ||
-            typeof arr[0] == "boolean"
+            typeof arr[0] == "boolean" ||
+            arr[0] === null
         ) {
             return true;
         } else {

src/danfojs-browser/tests/core/generic.test.js

@@ -74,6 +74,19 @@ describe("Generic (NDFrame)", function () {
         "IndexError: Row index must contain unique values";
       });
     });
+
+    it("Successfully create a 2D Frame when first value is empty", function () {
+      let data = [ [ null, 20, 1 ], [ 20, 25, 3 ] ];
+      let ndframe = new dfd.NDframe({ data, isSeries: false });
+      //@ts-ignore
+      assert.deepEqual(ndframe.values, data);
+    });
+    it("Successfully create a 1D Frame when first value is empty", function () {
+      let data = [ null, 'bval2', 'bval3', 'bval4' ];
+      let ndframe = new dfd.NDframe({ data, isSeries: true });
+      //@ts-ignore
+      assert.deepEqual(ndframe.values, data);
+    });
   });
 
   describe("NDframe Created from JavaScript Object", function () {

src/danfojs-node/test/core/generic.test.ts

@@ -77,6 +77,19 @@ describe("Generic (NDFrame)", function () {
                     "IndexError: Row index must contain unique values"
             });
         });
+
+        it("Successfully create a 2D Frame when first value is empty", function () {
+            let data = [[null, 20, 1], [20, 25, 3]];
+            let ndframe = new NDframe({ data, isSeries: false });
+            //@ts-ignore
+            assert.deepEqual(ndframe.values, data);
+        });
+        it("Successfully create a 1D Frame when first value is empty", function () {
+            let data = [null, 'bval2', 'bval3', 'bval4'];
+            let ndframe = new NDframe({ data, isSeries: true });
+            //@ts-ignore
+            assert.deepEqual(ndframe.values, data);
+        });
     })
 
     describe("NDframe Created from JavaScript Object", function () {
@@ -123,70 +136,6 @@ describe("Generic (NDFrame)", function () {
             let ndframe = new NDframe({ data, isSeries: false });
             assert.deepEqual(ndframe.values as any, [["A", NaN], [NaN, 2]]);
         });
-        // it("NDframe created from json takes key position into consideration", function () {
-        //     let json_data = [{ A: "A", B: "B", C: "C" },
-        //     { A: "A", B: "B", C: "C" },
-        //     { C: "C", B: "B", A: "A" },
-        //     { A: "A", C: "C", B: "B" }];
-
-        //     let output = [
-        //         [
-        //             'A',
-        //             'B',
-        //             'C'
-        //         ],
-        //         [
-        //             'A',
-        //             'B',
-        //             'C'
-        //         ],
-        //         [
-        //             'A',
-        //             'B',
-        //             'C'
-        //         ],
-        //         [
-        //             'A',
-        //             'B',
-        //             'C'
-        //         ]
-        //     ];
-        //     let ndframe = new NDframe({ data: json_data, isSeries: false });
-        //     assert.deepEqual(ndframe.values, output);
-        // });
-
-        // it("NDframe created from json sets value to NaN if not present", function () {
-        //     let json_data = [{ A: "A", B: "B", C: "C" },
-        //     { A: "A", B: "B", C: "C" },
-        //     { C: "C", B: "B", A: "A" },
-        //     { A: "A", C: "C" }];
-
-        //     let output = [
-        //         [
-        //             'A',
-        //             'B',
-        //             'C'
-        //         ],
-        //         [
-        //             'A',
-        //             'B',
-        //             'C'
-        //         ],
-        //         [
-        //             'A',
-        //             'B',
-        //             'C'
-        //         ],
-        //         [
-        //             'A',
-        //             'B',
-        //             NaN
-        //         ]
-        //     ];
-        //     let ndframe = new NDframe({ data: json_data, isSeries: false });
-        //     assert.deepEqual(ndframe.values, output);
-        // });
-
     });
 
     describe("Replacing row data", function () {