Skip to content

Commit 94f8512

Browse files
authored
Merge pull request #367 from javascriptdata/fix/add-max
add max to list of arithmetic operations
2 parents 9bfda6d + 642731f commit 94f8512

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/danfojs-base/aggregators/groupby.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ export default class Groupby {
231231
private arithemetic(operation: {[key: string] : Array<string> | string} | string): { [key: string ]: {} } {
232232

233233
const opsName = [ "mean", "sum", "count", "mode", "std", "var", "cumsum", "cumprod",
234-
"cummax", "cummin", "median" , "min"];
234+
"cummax", "cummin", "median" , "min", "max"];
235235
if (typeof operation === "string" ) {
236236
if (!opsName.includes(operation)) {
237237
throw new Error(`group operation: ${operation} is not valid`)

0 commit comments

Comments
 (0)