⚙️ Remove explicit any types from 16 TypeScript files (#60657)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: heiskr

eslint.config.ts

@@ -219,46 +219,30 @@ export default [
       'src/content-linter/tests/lint-frontmatter-links.ts',
       'src/content-linter/tests/unit/table-column-integrity-simple.ts',
       'src/content-render/liquid/engine.ts',
-      'src/content-render/liquid/ifversion.ts',
-      'src/content-render/liquid/indented-data-reference.ts',
       'src/content-render/liquid/index.ts',
-      'src/content-render/liquid/octicon.ts',
-      'src/content-render/scripts/add-content-type.ts',
       'src/content-render/scripts/liquid-tags.ts',
-      'src/content-render/scripts/move-by-content-type.ts',
       'src/content-render/scripts/move-content.ts',
-      'src/content-render/tests/data.ts',
       'src/content-render/tests/link-error-line-numbers.ts',
       'src/content-render/unified/annotate.ts',
       'src/content-render/unified/index.ts',
-      'src/content-render/unified/module-types.d.ts',
-      'src/content-render/unified/rewrite-local-links.ts',
       'src/data-directory/lib/get-data.ts',
       'src/early-access/scripts/migrate-early-access-product.ts',
-      'src/early-access/scripts/what-docs-early-access-branch.ts',
       'src/fixtures/tests/categories-and-subcategory.ts',
       'src/fixtures/tests/guides.ts',
       'src/fixtures/tests/translations.ts',
-      'src/frame/components/context/ArticleContext.tsx',
-      'src/frame/components/context/CategoryLandingContext.tsx',
       'src/frame/components/context/MainContext.tsx',
-      'src/frame/components/context/TocLandingContext.tsx',
       'src/frame/lib/create-tree.ts',
       'src/frame/lib/frontmatter.ts',
       'src/frame/lib/page-data.ts',
       'src/frame/lib/page.ts',
-      'src/frame/lib/read-frontmatter.ts',
       'src/frame/tests/page.ts',
-      'src/frame/tests/read-frontmatter.ts',
       'src/frame/tests/server.ts',
-      'src/ghes-releases/scripts/deprecate/update-content.ts',
       'src/github-apps/lib/index.ts',
       'src/graphql/lib/index.ts',
       'src/graphql/pages/reference.tsx',
       'src/graphql/scripts/utils/process-schemas.ts',
       'src/graphql/scripts/utils/schema-helpers.ts',
       'src/graphql/tests/validate-schema.ts',
-      'src/journeys/lib/journey-path-resolver.ts',
       'src/landings/components/CookBookFilter.tsx',
       'src/landings/components/ProductGuidesContext.tsx',
       'src/landings/components/ProductLandingContext.tsx',
@@ -271,7 +255,6 @@ export default [
       'src/links/lib/update-internal-links.ts',
       'src/links/scripts/check-github-github-links.ts',
       'src/links/scripts/update-internal-links.ts',
-      'src/redirects/middleware/handle-redirects.ts',
       'src/rest/components/get-rest-code-samples.ts',
       'src/rest/lib/index.ts',
       'src/rest/pages/category.tsx',
@@ -307,7 +290,6 @@ export default [
       'src/types/markdownlint-rule-helpers.d.ts',
       'src/types/markdownlint-rule-search-replace.d.ts',
       'src/types/primer__octicons.d.ts',
-      'src/versions/scripts/use-short-versions.ts',
       'src/workflows/projects.ts',
     ],
     rules: {

src/content-linter/lib/linting-rules/frontmatter-schema.ts

@@ -2,7 +2,6 @@ import { addError } from 'markdownlint-rule-helpers'
 import { intersection } from 'lodash-es'
 
 import { getFrontmatter } from '../helpers/utils'
-import { formatAjvErrors } from '../helpers/schema-utils'
 import { frontmatter, deprecatedProperties } from '@/frame/lib/frontmatter'
 import readFrontmatter from '@/frame/lib/read-frontmatter'
 import type { RuleParams, RuleErrorCallback, Rule } from '../../types'
@@ -35,23 +34,46 @@ export const frontmatterSchema: Rule = {
       )
     }
 
-    // Check that the frontmatter matches the schema
+    // Check that the frontmatter matches the schema.
+    // readFrontmatter returns errors as { property, message, reason } objects.
     const { errors } = readFrontmatter(params.lines.join('\n'), { schema: frontmatter.schema })
-    const formattedErrors = formatAjvErrors(
-      errors as unknown as Parameters<typeof formatAjvErrors>[0],
-    )
-    for (const error of formattedErrors) {
-      // If the missing property is at the top level, we don't have a line
+    for (const error of errors) {
+      const property = error.property || ''
+      const message = error.message || ''
+      const reason = error.reason || ''
+      const parts = property.split('.')
+
+      let detail: string
+      let context: string
+      let searchProperty: string
+
+      if (reason === 'additionalProperties') {
+        detail = 'The frontmatter includes an unsupported property.'
+        context = `Remove the property \`${property}\`.`
+        // Search for the offending additional property directly
+        searchProperty = parts[parts.length - 1] || ''
+      } else if (reason === 'required') {
+        detail = 'The frontmatter has a missing required property'
+        context = `Add the missing property \`${property}\``
+        // The property is missing, so point to its parent container
+        searchProperty = parts.length > 1 ? parts[parts.length - 2] : ''
+      } else {
+        detail = `Frontmatter ${message}.`
+        context = property
+        searchProperty = parts[0] || ''
+      }
+
+      // If the property is at the top level or missing, we don't have a line
       // to point to. In that case, the error will be added to line 1.
-      const query = (line: string) => line.trim().startsWith(`${error.searchProperty}:`)
-      const line = error.searchProperty === '' ? null : params.lines.find(query)
+      const query = (line: string) => line.trim().startsWith(`${searchProperty}:`)
+      const line = searchProperty === '' ? null : params.lines.find(query)
       const lineNumber = line ? params.lines.indexOf(line) + 1 : 1
       addError(
         onError,
         lineNumber,
-        error.detail,
-        error.context,
-        line ? [1, error.errorProperty.length] : null,
+        detail,
+        context,
+        line ? [1, searchProperty.length] : null,
         null, // No fix possible
       )
     }

src/content-render/liquid/ifversion.ts

@@ -8,6 +8,7 @@ import {
   type Emitter,
   type Template,
   type TopLevelToken,
+  type Liquid,
 } from 'liquidjs'
 import versionSatisfiesRange from '@/versions/lib/version-satisfies-range'
 import supportedOperators, {
@@ -26,6 +27,11 @@ interface VersionObj {
   internalLatestRelease?: string
 }
 
+interface IfversionEnvironments {
+  currentVersionObj?: VersionObj
+  markdownRequested?: boolean
+}
+
 const SyntaxHelp =
   "Syntax Error in 'ifversion' with range - Valid syntax: ifversion [plan] [operator] [releaseNumber]"
 
@@ -44,7 +50,7 @@ export default class Ifversion extends Tag {
   currentVersionObj: VersionObj | null = null
 
   // The following is verbatim from https://github.com/harttle/liquidjs/blob/v9.22.1/src/builtin/tags/if.ts
-  constructor(tagToken: TagToken, remainTokens: TopLevelToken[], liquid: any) {
+  constructor(tagToken: TagToken, remainTokens: TopLevelToken[], liquid: Liquid) {
     super(tagToken, remainTokens, liquid)
 
     this.tagToken = tagToken
@@ -60,7 +66,7 @@ export default class Ifversion extends Tag {
           templates: (p = []),
         }),
       )
-      .on('tag:elsif', (token: any) => {
+      .on('tag:elsif', (token: TagToken) => {
         this.branches.push({
           cond: token.args,
           templates: (p = []),
@@ -78,10 +84,10 @@ export default class Ifversion extends Tag {
 
   // The following is _mostly_ verbatim from https://github.com/harttle/liquidjs/blob/v9.22.1/src/builtin/tags/if.ts
   // The additions here are the handleNots(), handleOperators(), and handleVersionNames() calls.
-  *render(ctx: Context, emitter: Emitter): Generator<any, void, unknown> {
+  *render(ctx: Context, emitter: Emitter): Generator<unknown, void, unknown> {
     const r = this.liquid.renderer
 
-    this.currentVersionObj = (ctx.environments as any).currentVersionObj
+    this.currentVersionObj = (ctx.environments as IfversionEnvironments).currentVersionObj ?? null
 
     for (const branch of this.branches) {
       let resolvedBranchCond = branch.cond
@@ -96,7 +102,7 @@ export default class Ifversion extends Tag {
       // Resolve version names to boolean values for Markdown API context.
       // This will replace syntax like `fpt or ghec` with `true or false` based on current version.
       // Only apply this transformation in Markdown API context to avoid breaking existing functionality.
-      if ((ctx.environments as any).markdownRequested) {
+      if ((ctx.environments as IfversionEnvironments).markdownRequested) {
         resolvedBranchCond = this.handleVersionNames(resolvedBranchCond)
       }
 

src/content-render/liquid/indented-data-reference.ts

@@ -1,20 +1,13 @@
 import assert from 'assert'
 
+import { type TagToken, type Liquid } from 'liquidjs'
 import { THROW_ON_EMPTY, IndentedDataReferenceError } from './error-handling'
 import { getDataByLanguage } from '@/data-directory/lib/get-data'
 
-// Note: Using 'any' for liquidjs-related types because liquidjs doesn't provide comprehensive TypeScript definitions
-interface LiquidTag {
-  markup: string
-  liquid: any
-  parse(tagToken: any): void
-  render(scope: any): Promise<string | undefined>
-}
-
 interface LiquidScope {
   environments: {
     currentLanguage: string
-    [key: string]: any
+    [key: string]: unknown
   }
 }
 
@@ -28,11 +21,11 @@ interface LiquidScope {
 // reference is used inside a block element (like a list or nested list) without
 // affecting the formatting when the reference is used elsewhere via {{ site.data.foo.bar }}.
 
-const IndentedDataReference: LiquidTag = {
+const IndentedDataReference = {
   markup: '',
-  liquid: null as any,
+  liquid: null as Liquid | null,
 
-  parse(tagToken: any): void {
+  parse(tagToken: TagToken): void {
     this.markup = tagToken.args.trim()
   },
 

src/content-render/liquid/octicon.ts

@@ -1,21 +1,6 @@
-import { TokenizationError } from 'liquidjs'
+import { TokenizationError, type TagToken } from 'liquidjs'
 import octicons from '@primer/octicons'
 
-// Note: Using 'any' for liquidjs-related types because liquidjs doesn't provide comprehensive TypeScript definitions
-interface LiquidTag {
-  icon: string
-  options: Record<string, string>
-  parse(tagToken: any): void
-  render(): Promise<string>
-}
-
-interface OcticonsMatch {
-  groups: {
-    icon: string
-    options?: string
-  }
-}
-
 const OptionsSyntax = /([a-zA-Z-]+)="([\w\s-]+)"*/g
 const Syntax = new RegExp(`"(?<icon>[a-zA-Z-]+)"(?<options>(?:\\s${OptionsSyntax.source})*)`)
 const SyntaxHelp = 'Syntax Error in tag \'octicon\' - Valid syntax: octicon "<name>" <key="value">'
@@ -30,13 +15,13 @@ const SyntaxHelp = 'Syntax Error in tag \'octicon\' - Valid syntax: octicon "<na
  * {% octicon "check" %} <!-- auto-generates aria-label="check icon" -->
  * {% octicon "check" width="64" aria-label="Example label" %}
  */
-const Octicon: LiquidTag = {
+const Octicon = {
   icon: '',
-  options: {},
+  options: {} as Record<string, string>,
 
-  parse(tagToken: any): void {
-    const match: OcticonsMatch | null = tagToken.args.match(Syntax)
-    if (!match) {
+  parse(tagToken: TagToken): void {
+    const match = tagToken.args.match(Syntax)
+    if (!match || !match.groups) {
       throw new TokenizationError(SyntaxHelp, tagToken)
     }
 

src/content-render/scripts/add-content-type.ts

@@ -128,7 +128,15 @@ function processFile(filePath: string, scriptOptions: ScriptOptions) {
   }
 
   // Write the file back
-  fs.writeFileSync(filePath, frontmatter.stringify(content, data, { lineWidth: -1 } as any))
+  fs.writeFileSync(
+    filePath,
+    frontmatter.stringify(
+      content,
+      data,
+      // lineWidth is a js-yaml option passed through gray-matter, not in gray-matter's type definitions
+      { lineWidth: -1 } as unknown as Parameters<typeof frontmatter.stringify>[2],
+    ),
+  )
 
   if (scriptOptions.verbose) {
     console.log(`\n${relativePath}`)

src/content-render/scripts/move-by-content-type.ts

@@ -146,7 +146,7 @@ program
         }
 
         // Validate contentType
-        if (!CONTENT_TYPES.includes(contentType as any)) {
+        if (!CONTENT_TYPES.includes(contentType)) {
           skipped.push({ file: relativePath, reason: `Invalid contentType: ${contentType}` })
           console.log(
             chalk.yellow(`⚠ Skipping ${relativePath}: Invalid contentType "${contentType}"`),

src/content-render/tests/data.ts

@@ -6,8 +6,7 @@ import nonEnterpriseDefaultVersion from '@/versions/lib/non-enterprise-default-v
 import { DataDirectory } from '@/tests/helpers/data-directory'
 
 describe('data tag', () => {
-  // Using 'any' type as DataDirectory is from data-directory.ts which lacks type definitions
-  let dd: any
+  let dd: DataDirectory
   const enDirBefore = languages.en.dir
 
   beforeAll(() => {

src/content-render/unified/module-types.d.ts

@@ -19,7 +19,7 @@ declare module 'rehype-highlight' {
   import type { Options } from 'lowlight'
 
   interface HighlightOptions extends Options {
-    languages?: Record<string, any>
+    languages?: Record<string, unknown>
     subset?: boolean
     aliases?: Record<string, string>
   }

src/content-render/unified/rewrite-local-links.ts

@@ -101,12 +101,13 @@ export default function rewriteLocalLinks(context?: Context) {
       const linkRefNode = node as LinkReference
       const definition = definitions.get(linkRefNode.identifier)
       if (definition) {
-        // Replace the LinkReference node with a Link node
-        // Using 'as any' because we're mutating the node type at runtime,
-        // which TypeScript doesn't allow as LinkReference and Link are incompatible types
-        ;(linkRefNode as any).type = 'link'
-        ;(linkRefNode as any).url = definition.url
-        ;(linkRefNode as any).title = definition.title
+        // Replace the LinkReference node with a Link node by mutating its
+        // properties at runtime. Using 'as unknown as' because LinkReference
+        // and Link are structurally incompatible in TypeScript.
+        const mutableNode = linkRefNode as unknown as Link
+        mutableNode.type = 'link'
+        mutableNode.url = definition.url
+        mutableNode.title = definition.title
       } else {
         console.warn(`Definition not found for identifier: ${linkRefNode.identifier}`)
       }