⚙️ Remove explicit any types from 16 TypeScript files (#60746)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: heiskr

eslint.config.ts

@@ -204,32 +204,17 @@ export default [
       'src/article-api/transformers/audit-logs-transformer.ts',
       'src/article-api/transformers/rest-transformer.ts',
       'src/codeql-cli/scripts/convert-markdown-for-docs.ts',
-      'src/content-linter/lib/init-test.ts',
-      'src/content-linter/lib/linting-rules/code-annotations.ts',
-      'src/content-linter/lib/linting-rules/index.ts',
-      'src/content-linter/lib/linting-rules/journey-tracks-liquid.ts',
       'src/content-linter/lib/linting-rules/liquid-ifversion-versions.ts',
-      'src/content-linter/lib/linting-rules/liquid-versioning.ts',
-      'src/content-linter/lib/linting-rules/third-party-action-pinning.ts',
       'src/content-linter/scripts/lint-content.ts',
-      'src/content-linter/scripts/pretty-print-results.ts',
-      'src/content-linter/style/base.ts',
-      'src/content-linter/tests/integration/lint-cli.ts',
-      'src/content-linter/tests/lint-files.ts',
-      'src/content-linter/tests/lint-frontmatter-links.ts',
-      'src/content-linter/tests/unit/table-column-integrity-simple.ts',
+
       'src/content-render/liquid/engine.ts',
       'src/content-render/liquid/index.ts',
       'src/content-render/scripts/liquid-tags.ts',
       'src/content-render/scripts/move-content.ts',
-      'src/content-render/tests/link-error-line-numbers.ts',
       'src/content-render/unified/annotate.ts',
       'src/content-render/unified/index.ts',
       'src/data-directory/lib/get-data.ts',
-      'src/early-access/scripts/migrate-early-access-product.ts',
-      'src/fixtures/tests/categories-and-subcategory.ts',
       'src/fixtures/tests/guides.ts',
-      'src/fixtures/tests/translations.ts',
       'src/frame/components/context/MainContext.tsx',
       'src/frame/lib/create-tree.ts',
       'src/frame/lib/frontmatter.ts',
@@ -290,7 +275,6 @@ export default [
       'src/types/markdownlint-rule-helpers.d.ts',
       'src/types/markdownlint-rule-search-replace.d.ts',
       'src/types/primer__octicons.d.ts',
-      'src/workflows/projects.ts',
     ],
     rules: {
       '@typescript-eslint/no-explicit-any': 'off',

src/content-linter/lib/init-test.ts

@@ -23,7 +23,9 @@ export async function runRule(
   }
 
   const testOptions: Partial<Options> = {
-    customRules: [module as any],
+    customRules: [
+      module as unknown as NonNullable<Extract<Options['customRules'], unknown[]>>[number],
+    ],
     config: { ...defaultConfig, ...testConfig },
   }
   if (strings) testOptions.strings = strings

src/content-linter/lib/linting-rules/code-annotations.ts

@@ -5,7 +5,7 @@ import type { RuleParams, RuleErrorCallback, MarkdownToken } from '@/content-lin
 
 interface Frontmatter {
   layout?: string
-  [key: string]: any
+  [key: string]: unknown
 }
 
 export const codeAnnotations = {

src/content-linter/lib/linting-rules/index.ts

@@ -58,13 +58,10 @@ import { raiAppCardStructure } from '@/content-linter/lib/linting-rules/rai-app-
 import { frontmatterContentType } from '@/content-linter/lib/linting-rules/frontmatter-content-type'
 import { frontmatterDocsTeamMetrics } from '@/content-linter/lib/linting-rules/frontmatter-docs-team-metrics'
 
-// Using any type because @github/markdownlint-github doesn't provide TypeScript declarations
-// The elements in the array have a 'names' property that contains rule identifiers
-const noDefaultAltText = markdownlintGitHub.find((elem: any) =>
+const noDefaultAltText = markdownlintGitHub.find((elem: { names: string[] }) =>
   elem.names.includes('no-default-alt-text'),
 )
-// Using any type because @github/markdownlint-github doesn't provide TypeScript declarations
-const noGenericLinkText = markdownlintGitHub.find((elem: any) =>
+const noGenericLinkText = markdownlintGitHub.find((elem: { names: string[] }) =>
   elem.names.includes('no-generic-link-text'),
 )
 

src/content-linter/lib/linting-rules/journey-tracks-liquid.ts

@@ -9,8 +9,7 @@ export const journeyTracksLiquid = {
   description: 'Journey track properties must use valid Liquid syntax',
   tags: ['frontmatter', 'journey-tracks', 'liquid'],
   function: (params: RuleParams, onError: RuleErrorCallback) => {
-    // Using any for frontmatter as it's a dynamic YAML object with varying properties
-    const fm: any = getFrontmatter(params.lines)
+    const fm: Record<string, unknown> = getFrontmatter(params.lines) as Record<string, unknown>
     if (!fm || !fm.journeyTracks || !Array.isArray(fm.journeyTracks)) return
     if (!fm.layout || fm.layout !== 'journey-landing') return
 
@@ -23,7 +22,7 @@ export const journeyTracksLiquid = {
       : 1
 
     for (let trackIndex = 0; trackIndex < fm.journeyTracks.length; trackIndex++) {
-      const track: any = fm.journeyTracks[trackIndex]
+      const track = (fm.journeyTracks as Array<Record<string, unknown>>)[trackIndex]
       // Try to find the line number for this specific journey track so we can use that for the error
       // line number.  Getting the exact line number is probably more work than it's worth for this
       // particular rule.
@@ -62,11 +61,11 @@ export const journeyTracksLiquid = {
         if (prop.value && typeof prop.value === 'string') {
           try {
             liquid.parse(prop.value)
-          } catch (error: any) {
+          } catch (error: unknown) {
             addError(
               onError,
               trackLineNumber,
-              `Invalid Liquid syntax in journey track ${prop.name} (track ${trackIndex + 1}): ${error.message}`,
+              `Invalid Liquid syntax in journey track ${prop.name} (track ${trackIndex + 1}): ${error instanceof Error ? error.message : String(error)}`,
               prop.value,
             )
           }
@@ -84,11 +83,11 @@ export const journeyTracksLiquid = {
           if ('href' in guideObj && typeof guideObj.href === 'string') {
             try {
               liquid.parse(guideObj.href)
-            } catch (error: any) {
+            } catch (error: unknown) {
               addError(
                 onError,
                 trackLineNumber,
-                `Invalid Liquid syntax in journey track guide href (track ${trackIndex + 1}, guide ${guideIndex + 1}): ${error.message}`,
+                `Invalid Liquid syntax in journey track guide href (track ${trackIndex + 1}, guide ${guideIndex + 1}): ${error instanceof Error ? error.message : String(error)}`,
                 guideObj.href,
               )
             }
@@ -101,11 +100,11 @@ export const journeyTracksLiquid = {
           ) {
             try {
               liquid.parse(guideObj.alternativeNextStep)
-            } catch (error: any) {
+            } catch (error: unknown) {
               addError(
                 onError,
                 trackLineNumber,
-                `Invalid Liquid syntax in journey track guide alternativeNextStep (track ${trackIndex + 1}, guide ${guideIndex + 1}): ${error.message}`,
+                `Invalid Liquid syntax in journey track guide alternativeNextStep (track ${trackIndex + 1}, guide ${guideIndex + 1}): ${error instanceof Error ? error.message : String(error)}`,
                 guideObj.alternativeNextStep,
               )
             }

src/content-linter/lib/linting-rules/liquid-versioning.ts

@@ -169,9 +169,8 @@ function validateIfversionConditionals(cond: string, possibleVersionNames: Set<s
           `Found "${version}" inside "${cond}" with a "${operator}" operator, but "${version}" does not support semantic comparisons"`,
         )
       }
-      // Using 'as any' because the operator is a runtime string value that we validate,
       // but the allowedVersionOperators array has a more specific type that TypeScript can't infer
-      if (!allowedVersionOperators.includes(operator as any)) {
+      if (!(allowedVersionOperators as readonly string[]).includes(operator)) {
         errors.push(
           `Found a "${operator}" operator inside "${cond}", but "${operator}" is not supported`,
         )
@@ -259,11 +258,9 @@ function getVersionsObject(part: string, allFeatures: AllFeatures): Record<strin
   const versions: Record<string, string> = {}
   if (part in allFeatures) {
     for (const [shortName, version] of Object.entries(allFeatures[part].versions)) {
-      // Using 'as any' for recursive getVersionsObject call because it can return either
-      // a string or a nested Record<string, string>, but we flatten it to string for this context
       const versionOperator: string =
         version in allFeatures
-          ? (getVersionsObject(version, allFeatures) as any)
+          ? Object.values(getVersionsObject(version, allFeatures))[0] || '*'
           : (version as string)
       if (shortName in versions) {
         versions[shortName] = lowestVersion(versionOperator, versions[shortName])

src/content-linter/lib/linting-rules/third-party-action-pinning.ts

@@ -14,18 +14,18 @@ const firstPartyPrefixes = ['actions/', './.github/actions/', 'github/', 'octo-o
 
 interface WorkflowStep {
   uses?: string
-  [key: string]: any
+  [key: string]: unknown
 }
 
 interface WorkflowJob {
   steps?: WorkflowStep[]
-  [key: string]: any
+  [key: string]: unknown
 }
 
 interface WorkflowYaml {
   jobs?: Record<string, WorkflowJob>
   steps?: WorkflowStep[]
-  [key: string]: any
+  [key: string]: unknown
 }
 
 export const thirdPartyActionPinning: Rule = {

src/content-linter/scripts/pretty-print-results.ts

@@ -152,8 +152,8 @@ function chalkFunColors(text: string): string {
     .map((char) => {
       const color = shuffledColors[colorIndex]
       colorIndex = (colorIndex + 1) % shuffledColors.length
-      // Chalk's TypeScript types don't support dynamic property access, but these are valid color methods
-      return (chalk as any)[color](char)
+      const colorFn = chalk[color] as (text: string) => string
+      return colorFn(char)
     })
     .join('')
 }

src/content-linter/style/base.ts

@@ -9,7 +9,7 @@ type RuleConfig = {
   severity: 'error' | 'warning'
   'partial-markdown-files': boolean
   'yml-files': boolean
-  [key: string]: any
+  [key: string]: unknown
 }
 
 type BaseConfig = {

src/content-linter/tests/integration/lint-cli.ts

@@ -52,9 +52,10 @@ describe('Content Linter CLI Integration Tests', { timeout: 30000 }, () => {
         stdio: 'pipe',
         timeout: 10000, // 10 second timeout
       })
-    } catch (error: any) {
-      output = error.stdout + error.stderr
-      exitCode = error.status || 1
+    } catch (error: unknown) {
+      const execError = error as { stdout?: string; stderr?: string; status?: number }
+      output = (execError.stdout || '') + (execError.stderr || '')
+      exitCode = execError.status || 1
     }
 
     return { output, exitCode }