Skip to content

Commit d36a799

Browse files
committed
make banner images responsive and remove table banner variant
Banner images were not scaling on mobile, so they appeared oversized/disproportionate and triggered horizontal page overflow. Apply responsive image sizing in `.banner` (`max-width: 100%`, `height: auto`) so banner images scale correctly. Non-home pages also used a table-based banner layout, which is generally not mobile-friendly and makes it harder to position, contain, and scale content within smaller viewports. It also introduced unnecessary branding inconsistency across desktop and mobile: the home page and non-home pages presented essentially the same banner content with different proportions and visual behavior but still serving the same purpose and content. Rather than making the table layout itself responsive, remove it entirely. The home page already had a working non-table structure, and a single shared layout is simpler to maintain and style. Remove that page-kind split and use one shared banner structure (logo + subtitle in .banner) so banner behavior and branding are consistent on mobile and desktop across the site.
1 parent f5f29d4 commit d36a799

2 files changed

Lines changed: 3 additions & 17 deletions

File tree

assets/sass/main.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ body {
1616
.banner {
1717
text-align: center;
1818
font-weight: bold;
19-
td img {
20-
height: 150px;
19+
img {
20+
max-width: 100%;
21+
height: auto;
2122
}
2223
}
2324
big {

layouts/partials/banner.html

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,6 @@
77
<small>... one iteration at a time... </small>
88
{{- end -}}
99
<div class="banner">
10-
{{- if eq .Kind "home" }}
1110
{{ partial "logo.html" . }}
1211
{{ partial "subtitle.html" . }}
13-
{{- else }}
14-
<table style="width: 100%">
15-
<tbody>
16-
<tr>
17-
<td>
18-
{{ partial "logo.html" . }}
19-
</td>
20-
<td>
21-
{{ partial "subtitle.html" . }}
22-
</td>
23-
</tr>
24-
</tbody>
25-
</table>
26-
{{- end }}
2712
</div>{{ if eq .Kind "home" }}<hr />{{ end }}

0 commit comments

Comments
 (0)