Skip to content

Commit 149248b

Browse files
committed
BAEL-8605: improvements
1 parent 0bb7f2b commit 149248b

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

spring-boot-modules/spring-boot-3-observation/pom.xml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,12 @@
4747
<artifactId>micrometer-tracing-test</artifactId>
4848
<scope>test</scope>
4949
</dependency>
50+
<dependency>
51+
<groupId>org.assertj</groupId>
52+
<artifactId>assertj-core</artifactId>
53+
<version>${assertj-core.version}</version>
54+
<scope>test</scope>
55+
</dependency>
5056
<!-- get ObservationRegistry configured -->
5157
<dependency>
5258
<groupId>org.springframework.boot</groupId>
@@ -140,7 +146,8 @@
140146
<start-class>com.baeldung.samples.SimpleObservationApplication</start-class>
141147
<p6spy-spring-boot-starter.version>1.12.1</p6spy-spring-boot-starter.version>
142148
<datasource-proxy-spring-boot-starter.version>1.12.1</datasource-proxy-spring-boot-starter.version>
143-
<micrometer.version>1.15.3</micrometer.version>
149+
<assertj-core.version>4.0.0-M1</assertj-core.version>
150+
<micrometer.version>1.17.0-M1</micrometer.version>
144151
<spring-boot.version>3.5.8</spring-boot.version>
145152
<logback.version>1.5.20</logback.version>
146153
<slf4j.version>2.0.17</slf4j.version>

spring-boot-modules/spring-boot-3-observation/src/test/java/com/baeldung/micrometer/test/MicrometerUnitTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,19 @@ void whenFooIsCalled_thenTimerIsUpdated() {
4545
}
4646

4747
@Test
48-
void whenFooIsCalled_thenTimerIsRegistered() {
48+
void whenFooIsCalled_thenTimerAndCounterAreRegistered() {
49+
fooService.foo();
50+
fooService.foo();
4951
fooService.foo();
5052

5153
MeterRegistryAssert.assertThat(meterRegistry)
52-
.hasTimerWithName("foo.time");
54+
.counter("foo.count")
55+
.hasCount(3);
56+
57+
MeterRegistryAssert.assertThat(meterRegistry)
58+
.timer("foo.time")
59+
.totalTime()
60+
.isBetween(ofMillis(30), ofMillis(400));
5361
}
5462

5563
}

0 commit comments

Comments
 (0)