Skip to content

Commit 0eedcd5

Browse files
committed
improve hook
1 parent 2d9e639 commit 0eedcd5

2 files changed

Lines changed: 24 additions & 18 deletions

File tree

  • packages/devtool-extenstion

packages/devtool-extenstion/extension/core/hook.js

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -202,19 +202,21 @@ export function installHook(target, settings) {
202202

203203
if (
204204
settings.debugUseReducer &&
205-
renderer &&
206-
window.__REACT_CONTEXT_DEVTOOL_GLOBAL_HOOK.hookHelperLoaded &&
205+
_debugHookTypes &&
206+
_debugHookTypes.length &&
207+
// renderer &&
208+
// window.__REACT_CONTEXT_DEVTOOL_GLOBAL_HOOK.hookHelperLoaded &&
207209
memoizedState &&
208210
Object.hasOwnProperty.call(memoizedState, "baseState")
209211
) {
210-
if (!_debugHookTypes || !_debugHookTypes.length) {
211-
try {
212-
window.__REACT_CONTEXT_DEVTOOL_GLOBAL_HOOK.helpers.inspectHooksOfFiber(
213-
fiberNode,
214-
renderer
215-
);
216-
} catch(err) {}
217-
}
212+
// if (!_debugHookTypes || !_debugHookTypes.length) {
213+
// try {
214+
// window.__REACT_CONTEXT_DEVTOOL_GLOBAL_HOOK.helpers.inspectHooksOfFiber(
215+
// fiberNode,
216+
// renderer
217+
// );
218+
// } catch(err) {}
219+
// }
218220

219221
let temp = memoizedState;
220222
const hookTypes = _debugHookTypes || [];
@@ -333,13 +335,14 @@ export function installHook(target, settings) {
333335
const loadHelperAndDebugFiber = (params) => {
334336
isDebuggingStarted = true;
335337

336-
if (settings.debugUseReducer && !window.__REACT_CONTEXT_DEVTOOL_GLOBAL_HOOK.hookHelperLoaded) {
337-
target.__REACT_CONTEXT_DEVTOOL_GLOBAL_HOOK.helpers.loadHookHelper().then(() => {
338-
debugFiber(params);
339-
});
340-
} else {
341-
debugFiber(params);
342-
}
338+
debugFiber(params);
339+
// if (settings.debugUseReducer && !window.__REACT_CONTEXT_DEVTOOL_GLOBAL_HOOK.hookHelperLoaded) {
340+
// target.__REACT_CONTEXT_DEVTOOL_GLOBAL_HOOK.helpers.loadHookHelper().then(() => {
341+
// debugFiber(params);
342+
// });
343+
// } else {
344+
// debugFiber(params);
345+
// }
343346
};
344347

345348
const startDebug = () => {

packages/devtool-extenstion/src/containers/Settings/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ const Settings = () => {
7878
<label htmlFor="extensionLoad" className="setting-radio-label">
7979
On Extensions Load
8080
<div className="light-text">
81-
Start data capturing after extenstion is opened in dev panel
81+
Start data capturing after extenstion is opened in dev panel (recommended)
8282
</div>
8383
</label>
8484
</div>
@@ -114,6 +114,9 @@ const Settings = () => {
114114
/>
115115
<label htmlFor="useReducer" className="setting-radio-label">
116116
useReducer
117+
<div className="light-text">
118+
Available only in development mode
119+
</div>
117120
</label>
118121
</div>
119122
<div className="setting-radio-wrapper">

0 commit comments

Comments
 (0)