Skip to content

Commit ca044f4

Browse files
committed
Require double confirmation for deleting all accounts
The user must check a checkbox to enable the delete button. This tries to avoid confirming irreversible actions by mistake. Fixes #544
1 parent c6518cb commit ca044f4

1 file changed

Lines changed: 2 additions & 12 deletions

File tree

app/src/main/java/org/gnucash/android/ui/settings/dialog/DeleteAllAccountsConfirmationDialog.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,10 @@
1616

1717
package org.gnucash.android.ui.settings.dialog;
1818

19-
import android.annotation.TargetApi;
20-
import android.app.AlertDialog;
2119
import android.app.Dialog;
2220
import android.content.Context;
2321
import android.content.DialogInterface;
2422
import android.os.Bundle;
25-
import android.support.v4.app.DialogFragment;
2623
import android.widget.Toast;
2724

2825
import org.gnucash.android.R;
@@ -36,7 +33,7 @@
3633
*
3734
* @author Ngewi Fet <ngewif@gmail.com>
3835
*/
39-
public class DeleteAllAccountsConfirmationDialog extends DialogFragment {
36+
public class DeleteAllAccountsConfirmationDialog extends DoubleConfirmationDialog {
4037

4138
public static DeleteAllAccountsConfirmationDialog newInstance() {
4239
DeleteAllAccountsConfirmationDialog frag = new DeleteAllAccountsConfirmationDialog();
@@ -45,7 +42,7 @@ public static DeleteAllAccountsConfirmationDialog newInstance() {
4542

4643
@Override
4744
public Dialog onCreateDialog(Bundle savedInstanceState) {
48-
return new AlertDialog.Builder(getActivity())
45+
return getDialogBuilder()
4946
.setIcon(android.R.drawable.ic_delete)
5047
.setTitle(R.string.title_confirm_delete).setMessage(R.string.confirm_delete_all_accounts)
5148
.setPositiveButton(R.string.alert_dialog_ok_delete,
@@ -59,13 +56,6 @@ public void onClick(DialogInterface dialog, int whichButton) {
5956
}
6057
}
6158
)
62-
.setNegativeButton(R.string.alert_dialog_cancel,
63-
new DialogInterface.OnClickListener() {
64-
public void onClick(DialogInterface dialog, int whichButton) {
65-
dismiss();
66-
}
67-
}
68-
)
6959
.create();
7060
}
7161
}

0 commit comments

Comments
 (0)