Fix imported weekly scheduled actions no having the days of the week set

Currently, days of the week aren't parsed for scheduled actions, so they
aren't set either. This ensures scheduled actions are executed at least
once per week by setting them to run on the day of the week of the start
time. It's a temporary workaround, in the future we should implement
parsing of days of the week.

Author: rivaldi8

app/src/main/java/org/gnucash/android/importer/GncXmlHandler.java

@@ -60,6 +60,9 @@
 import java.sql.Timestamp;
 import java.text.ParseException;
 import java.util.ArrayList;
+import java.util.Calendar;
+import java.util.Collections;
+import java.util.Date;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -791,6 +794,10 @@ public void endElement(String uri, String localName, String qualifiedName) throw
 
             case GncXmlHelper.TAG_SCHEDULED_ACTION:
                 if (mScheduledAction.getActionUID() != null && !mIgnoreScheduledAction) {
+                    if (mScheduledAction.getRecurrence().getPeriodType() == PeriodType.WEEK) {
+                        // TODO: implement parsing of by days for scheduled actions
+                        setMinimalScheduledActionByDays();
+                    }
                     mScheduledActionsList.add(mScheduledAction);
                     int count = generateMissedScheduledTransactions(mScheduledAction);
                     Log.i(LOG_TAG, String.format("Generated %d transactions from scheduled action", count));
@@ -1115,4 +1122,17 @@ private int generateMissedScheduledTransactions(ScheduledAction scheduledAction)
         scheduledAction.setLastRun(lastRuntime);
         return generatedTransactionCount;
     }
+
+    /**
+     * Sets the by days of the scheduled action to the day of the week of the start time.
+     *
+     * <p>Until we implement parsing of days of the week for scheduled actions,
+     * this ensures they are executed at least once per week.</p>
+     */
+    private void setMinimalScheduledActionByDays() {
+        Calendar calendar = Calendar.getInstance();
+        calendar.setTime(new Date(mScheduledAction.getStartTime()));
+        mScheduledAction.getRecurrence().setByDays(
+                Collections.singletonList(calendar.get(Calendar.DAY_OF_WEEK)));
+    }
 }

app/src/test/java/org/gnucash/android/test/unit/importer/GncXmlHandlerTest.java

@@ -22,13 +22,16 @@
 import org.gnucash.android.db.DatabaseHelper;
 import org.gnucash.android.db.adapter.AccountsDbAdapter;
 import org.gnucash.android.db.adapter.BooksDbAdapter;
+import org.gnucash.android.db.adapter.RecurrenceDbAdapter;
+import org.gnucash.android.db.adapter.ScheduledActionDbAdapter;
 import org.gnucash.android.db.adapter.SplitsDbAdapter;
 import org.gnucash.android.db.adapter.TransactionsDbAdapter;
 import org.gnucash.android.export.xml.GncXmlHelper;
 import org.gnucash.android.importer.GncXmlHandler;
 import org.gnucash.android.model.Account;
 import org.gnucash.android.model.AccountType;
 import org.gnucash.android.model.Money;
+import org.gnucash.android.model.ScheduledAction;
 import org.gnucash.android.model.Split;
 import org.gnucash.android.model.Transaction;
 import org.gnucash.android.model.TransactionType;
@@ -47,6 +50,8 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.text.ParseException;
+import java.util.Calendar;
+import java.util.Date;
 
 import javax.xml.parsers.ParserConfigurationException;
 import javax.xml.parsers.SAXParser;
@@ -64,6 +69,7 @@ public class GncXmlHandlerTest {
     private BooksDbAdapter mBooksDbAdapter;
     private TransactionsDbAdapter mTransactionsDbAdapter;
     private AccountsDbAdapter mAccountsDbAdapter;
+    private ScheduledActionDbAdapter mScheduledActionDbAdapter;
 
     @Before
     public void setUp() throws Exception {
@@ -95,6 +101,8 @@ private void setUpDbAdapters(String bookUID) {
         SQLiteDatabase mainDb = databaseHelper.getReadableDatabase();
         mTransactionsDbAdapter = new TransactionsDbAdapter(mainDb, new SplitsDbAdapter(mainDb));
         mAccountsDbAdapter = new AccountsDbAdapter(mainDb, mTransactionsDbAdapter);
+        RecurrenceDbAdapter recurrenceDbAdapter = new RecurrenceDbAdapter(mainDb);
+        mScheduledActionDbAdapter = new ScheduledActionDbAdapter(mainDb, recurrenceDbAdapter);
     }
 
     /**
@@ -334,6 +342,31 @@ public void simpleScheduledTransactionImport() throws ParseException {
         assertThat(split2.isPairOf(split1)).isTrue();
     }
 
+    /**
+     * Tests that importing a weekly scheduled action sets the days of the
+     * week of the recursion.
+     */
+    @Test
+    public void importingScheduledAction_shouldSetByDays() throws ParseException {
+        String bookUID = importGnuCashXml("importingScheduledAction_shouldSetByDays.xml");
+        setUpDbAdapters(bookUID);
+
+        ScheduledAction scheduledTransaction =
+                mScheduledActionDbAdapter.getRecord("b5a13acb5a9459ebed10d06b75bbad10");
+
+        // There are 3 byDays but, for now, getting one is enough to ensure it is executed
+        assertThat(scheduledTransaction.getRecurrence().getByDays().size()).isGreaterThanOrEqualTo(1);
+
+        // Until we implement parsing of days of the week for scheduled actions,
+        // we'll just use the day of the week of the start time.
+        int dayOfWeekFromByDays = scheduledTransaction.getRecurrence().getByDays().get(0);
+        Date startTime = new Date(scheduledTransaction.getStartTime());
+        Calendar calendar = Calendar.getInstance();
+        calendar.setTime(startTime);
+        int dayOfWeekFromStartTime = calendar.get(Calendar.DAY_OF_WEEK);
+        assertThat(dayOfWeekFromByDays).isEqualTo(dayOfWeekFromStartTime);
+    }
+
     /**
      * Checks for bug 562 - Scheduled transaction imported with imbalanced splits.
      *