Skip to content

Commit 32f0aca

Browse files
committed
Fix test for first run wizard (proper checking of created accounts)
Remove logging of books info to Crashlytics. Only print stacktrace to Android device logs
1 parent 035f37c commit 32f0aca

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

app/src/androidTest/java/org/gnucash/android/test/ui/FirstRunWizardActivityTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ public void shouldRunWizardToEnd(){
101101
onView(withId(R.id.btn_save)).perform(click());
102102

103103
//default accounts should be created
104-
assertThat(mAccountsDbAdapter.getRecordsCount()).isGreaterThan(60);
104+
long actualCount = GnuCashApplication.getAccountsDbAdapter().getRecordsCount();
105+
assertThat(actualCount).isGreaterThan(60L);
105106

106107
boolean enableCrashlytics = GnuCashApplication.isCrashlyticsEnabled();
107108
assertThat(enableCrashlytics).isTrue();

app/src/main/java/org/gnucash/android/db/adapter/BooksDbAdapter.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@
2424
import android.net.Uri;
2525
import android.support.annotation.NonNull;
2626

27-
import com.crashlytics.android.Crashlytics;
28-
2927
import org.gnucash.android.R;
3028
import org.gnucash.android.app.GnuCashApplication;
3129
import org.gnucash.android.db.DatabaseSchema.BookEntry;
@@ -167,7 +165,7 @@ public boolean isActive(String bookUID){
167165
"There is no active book in the app."
168166
+ "This should NEVER happen, fix your bugs!\n"
169167
+ getNoActiveBookFoundExceptionInfo());
170-
Crashlytics.logException(e);
168+
e.printStackTrace();
171169
throw e;
172170
}
173171
cursor.moveToFirst();

0 commit comments

Comments
 (0)