Adding a split to the transaction was removing more rows than it should have: old transaction had n rows; the new transaction has n+1 rows; but the (n+1)th row was "Balance".

Author: pnemonic78

app/src/main/java/org/gnucash/android/ui/transaction/TransactionDetailActivity.java

@@ -54,6 +54,7 @@ public class TransactionDetailActivity extends PasscodeLockActivity {
 
     private String mTransactionUID;
     private String mAccountUID;
+    private int mDetailTableRows;
 
     public static final int REQUEST_EDIT_TRANSACTION = 0x10;
 
@@ -126,6 +127,7 @@ private void bindViews(){
         TextView balanceTextView = accountBalance.isNegative() ? mDebitBalance : mCreditBalance;
         TransactionsActivity.displayBalance(balanceTextView, accountBalance);
 
+        mDetailTableRows = mDetailTableLayout.getChildCount();
         boolean useDoubleEntry = GnuCashApplication.isDoubleEntryEnabled();
         LayoutInflater inflater = LayoutInflater.from(this);
         int index = 0;
@@ -175,8 +177,8 @@ private void refresh(){
      * Remove the split item views from the transaction detail prior to refreshing them
      */
     private void removeSplitItemViews(){
-        long splitCount = TransactionsDbAdapter.getInstance().getSplitCount(mTransactionUID);
-        mDetailTableLayout.removeViews(0, (int)splitCount);
+        // Remove all rows that are not special.
+        mDetailTableLayout.removeViews(0, mDetailTableLayout.getChildCount() - mDetailTableRows);
         mDebitBalance.setText("");
         mCreditBalance.setText("");
     }

app/src/main/res/layout/activity_transaction_detail.xml

@@ -73,7 +73,8 @@
             android:stretchColumns="1"
             android:orientation="vertical" >
 
-            <TableRow android:layout_width="match_parent"
+            <TableRow android:id="@+id/row_balance"
+                android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:weightSum="5"
                 android:paddingTop="5dp"

app/src/main/res/layout/item_split_amount_info.xml

@@ -16,6 +16,7 @@
 -->
 <TableRow xmlns:tools="http://schemas.android.com/tools"
     xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/row_split_amount_info"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:weightSum="5"