Skip to content

Commit 0a5af15

Browse files
committed
Fix broken tests
1 parent a74311a commit 0a5af15

1 file changed

Lines changed: 25 additions & 7 deletions

File tree

app/src/test/java/org/gnucash/android/test/unit/service/ScheduledActionServiceTest.java

Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
import org.gnucash.android.util.BookUtils;
4949
import org.gnucash.android.util.TimestampHelper;
5050
import org.joda.time.DateTime;
51+
import org.joda.time.DateTimeConstants;
5152
import org.joda.time.LocalDateTime;
5253
import org.joda.time.Weeks;
5354
import org.junit.After;
@@ -63,6 +64,8 @@
6364
import java.math.BigDecimal;
6465
import java.sql.Timestamp;
6566
import java.util.ArrayList;
67+
import java.util.Calendar;
68+
import java.util.Collections;
6669
import java.util.List;
6770

6871
import javax.xml.parsers.ParserConfigurationException;
@@ -199,8 +202,10 @@ public void missedScheduledTransactions_shouldBeGenerated(){
199202

200203
scheduledAction.setActionUID(mActionUID);
201204

202-
int multiplier = 2;
203-
scheduledAction.setRecurrence(PeriodType.WEEK, multiplier);
205+
Recurrence recurrence = new Recurrence(PeriodType.WEEK);
206+
recurrence.setMultiplier(2);
207+
recurrence.setByDays(Collections.singletonList(Calendar.MONDAY));
208+
scheduledAction.setRecurrence(recurrence);
204209
ScheduledActionDbAdapter.getInstance().addRecord(scheduledAction, DatabaseAdapter.UpdateMethod.insert);
205210

206211
TransactionsDbAdapter transactionsDbAdapter = TransactionsDbAdapter.getInstance();
@@ -249,7 +254,10 @@ public void scheduledTransactionsWithEndTimeInPast_shouldBeExecuted(){
249254
scheduledAction.setStartTime(startTime.getMillis());
250255
scheduledAction.setActionUID(mActionUID);
251256

252-
scheduledAction.setRecurrence(PeriodType.WEEK, 2);
257+
Recurrence recurrence = new Recurrence(PeriodType.WEEK);
258+
recurrence.setMultiplier(2);
259+
recurrence.setByDays(Collections.singletonList(Calendar.MONDAY));
260+
scheduledAction.setRecurrence(recurrence);
253261
scheduledAction.setEndTime(new DateTime(2016, 8, 8, 9, 0).getMillis());
254262
ScheduledActionDbAdapter.getInstance().addRecord(scheduledAction, DatabaseAdapter.UpdateMethod.insert);
255263

@@ -345,11 +353,15 @@ public void scheduledBackups_shouldRunOnlyOnce(){
345353
@Test
346354
public void scheduledBackups_shouldNotRunBeforeNextScheduledExecution(){
347355
ScheduledAction scheduledBackup = new ScheduledAction(ScheduledAction.ActionType.BACKUP);
348-
scheduledBackup.setStartTime(LocalDateTime.now().minusDays(2).toDate().getTime());
356+
scheduledBackup.setStartTime(
357+
LocalDateTime.now().withDayOfWeek(DateTimeConstants.WEDNESDAY).toDate().getTime());
349358
scheduledBackup.setLastRun(scheduledBackup.getStartTime());
350359
long previousLastRun = scheduledBackup.getLastRunTime();
351360
scheduledBackup.setExecutionCount(1);
352-
scheduledBackup.setRecurrence(PeriodType.WEEK, 1);
361+
Recurrence recurrence = new Recurrence(PeriodType.WEEK);
362+
recurrence.setMultiplier(1);
363+
recurrence.setByDays(Collections.singletonList(Calendar.MONDAY));
364+
scheduledBackup.setRecurrence(recurrence);
353365

354366
ExportParams backupParams = new ExportParams(ExportFormat.XML);
355367
backupParams.setExportTarget(ExportParams.ExportTarget.SD_CARD);
@@ -380,7 +392,10 @@ public void scheduledBackups_shouldNotIncludeTransactionsPreviousToTheLastRun()
380392
scheduledBackup.setLastRun(LocalDateTime.now().minusDays(8).toDate().getTime());
381393
long previousLastRun = scheduledBackup.getLastRunTime();
382394
scheduledBackup.setExecutionCount(1);
383-
scheduledBackup.setRecurrence(PeriodType.WEEK, 1);
395+
Recurrence recurrence = new Recurrence(PeriodType.WEEK);
396+
recurrence.setMultiplier(1);
397+
recurrence.setByDays(Collections.singletonList(Calendar.WEDNESDAY));
398+
scheduledBackup.setRecurrence(recurrence);
384399
ExportParams backupParams = new ExportParams(ExportFormat.QIF);
385400
backupParams.setExportTarget(ExportParams.ExportTarget.SD_CARD);
386401
backupParams.setExportStartTime(new Timestamp(scheduledBackup.getStartTime()));
@@ -438,7 +453,10 @@ public void scheduledBackups_shouldIncludeTransactionsAfterTheLastRun() {
438453
scheduledBackup.setLastRun(LocalDateTime.now().minusDays(8).toDate().getTime());
439454
long previousLastRun = scheduledBackup.getLastRunTime();
440455
scheduledBackup.setExecutionCount(1);
441-
scheduledBackup.setRecurrence(PeriodType.WEEK, 1);
456+
Recurrence recurrence = new Recurrence(PeriodType.WEEK);
457+
recurrence.setMultiplier(1);
458+
recurrence.setByDays(Collections.singletonList(Calendar.FRIDAY));
459+
scheduledBackup.setRecurrence(recurrence);
442460
ExportParams backupParams = new ExportParams(ExportFormat.QIF);
443461
backupParams.setExportTarget(ExportParams.ExportTarget.SD_CARD);
444462
backupParams.setExportStartTime(new Timestamp(scheduledBackup.getStartTime()));

0 commit comments

Comments
 (0)