Skip to content

Commit cdbe9bf

Browse files
committed
comment out unused
1 parent ec7dcc1 commit cdbe9bf

1 file changed

Lines changed: 30 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1238,6 +1238,36 @@ jobs:
12381238
save-if: false
12391239
prefix-key: v1
12401240

1241+
# # This step shouldn't be needed, but somehow we end up with caches that are missing librusty_v8.a.
1242+
# # ChatGPT suspects that this could be due to different build invocations using the same target dir,
1243+
# # and this makes sense to me because we only see it in this job where we mix `cargo build -p` with
1244+
# # `cargo build --manifest-path` (which apparently build different dependency trees).
1245+
# # However, we've been unable to fix it so... /shrug
1246+
# - name: Check v8 outputs
1247+
# run: |
1248+
# find "${CARGO_TARGET_DIR}"/ -type f | grep '[/_]v8' || true
1249+
# if ! [ -f "${CARGO_TARGET_DIR}"/debug/gn_out/obj/librusty_v8.a ]; then
1250+
# echo "Could not find v8 output file librusty_v8.a; rebuilding manually."
1251+
# cargo clean -p v8 || true
1252+
# cargo build -p v8
1253+
# fi
1254+
# if ! [ -f "${CARGO_TARGET_DIR}"/release/gn_out/obj/librusty_v8.a ]; then
1255+
# echo "Could not find v8 output file librusty_v8.a; rebuilding manually."
1256+
# cargo clean --release -p v8 || true
1257+
# cargo build --release -p v8
1258+
# fi
1259+
1260+
# - name: Install SpacetimeDB CLI from the local checkout
1261+
# run: |
1262+
# export CARGO_HOME="$HOME/.cargo"
1263+
# echo "$CARGO_HOME/bin" >> "$GITHUB_PATH"
1264+
# cargo install --force --path crates/cli --locked --message-format=short
1265+
# cargo install --force --path crates/standalone --locked --message-format=short
1266+
# # Add a handy alias using the old binary name, so that we don't have to rewrite all scripts (incl. in submodules).
1267+
# ln -sf $CARGO_HOME/bin/spacetimedb-cli $CARGO_HOME/bin/spacetime
1268+
# # Clear any existing information
1269+
# spacetime server clear -y
1270+
12411271
- name: Run TypeScript tests
12421272
run: cargo ci typescript-test
12431273

0 commit comments

Comments
 (0)