revert

Author: bfops

tools/ci/src/main.rs

@@ -384,6 +384,8 @@ fn main() -> Result<()> {
 
     match cli.cmd {
         Some(CiCmd::Test) => {
+            cmd!("pnpm", "build").dir("crates/bindings-typescript").run()?;
+
             // TODO: This doesn't work on at least user Linux machines, because something here apparently uses `sudo`?
 
             // Exclude smoketests from `cargo test --all` since they require pre-built binaries.
@@ -541,6 +543,7 @@ fn main() -> Result<()> {
         }
 
         Some(CiCmd::Smoketests(args)) => {
+            ensure_repo_root()?;
             smoketest::run(args)?;
         }
 
@@ -551,7 +554,7 @@ fn main() -> Result<()> {
             let mut common_args = vec![];
             if let Some(target) = target.as_ref() {
                 common_args.push("--target");
-                common_args.push(target.as_str());
+                common_args.push(target);
                 log::info!("checking update flow for target: {target}");
             } else {
                 log::info!("checking update flow");
@@ -565,26 +568,24 @@ fn main() -> Result<()> {
                 "cargo",
                 ["build", "-p", "spacetimedb-update"]
                     .into_iter()
-                    .chain(common_args.iter().copied()),
+                    .chain(common_args.clone()),
             )
             .run()?;
-
+            // NOTE(bfops): We need the `github-token-auth` feature because we otherwise tend to get ratelimited when we try to fetch `/releases/latest`.
+            // My best guess is that, on the GitHub runners, the "anonymous" ratelimit is shared by *all* users of that runner (I think this because it
+            // happens very frequently on the `macos-runner`, but we haven't seen it on any others).
             let root_dir = tempfile::tempdir()?;
-            let root_arg = format!("--root-dir={}", root_dir.path().display());
+            let root_dir_string = root_dir.path().to_string_lossy().to_string();
+            let root_arg = format!("--root-dir={}", root_dir_string);
             cmd(
                 "cargo",
                 ["run", "-p", "spacetimedb-update"]
                     .into_iter()
-                    .chain(common_args.iter().copied())
+                    .chain(common_args.clone())
                     .chain(["--", "self-install", &root_arg, "--yes"].into_iter()),
             )
             .run()?;
-
-            let mut spacetime_path = root_dir.path().join("spacetime");
-            if !std::env::consts::EXE_EXTENSION.is_empty() {
-                spacetime_path.set_extension(std::env::consts::EXE_EXTENSION);
-            }
-            cmd(spacetime_path, [&root_arg, "help"]).run()?;
+            cmd!(format!("{}/spacetime", root_dir_string), &root_arg, "help",).run()?;
         }
 
         Some(CiCmd::CliDocs { spacetime_path }) => {