Add a new Resolve::generate_nominal_type_ids method (#2447)

* Add a new `Resolve::generate_nominal_type_ids` method

This commit adds a new method to `Resolve` which is intended to resolve
a longstanding issue for bindings generators based on `wit-parser`: #1497.
Specifically this adds functionality to `Resolve` to duplicate exported
interfaces and their contents, if necessary. This is a boon to bindings
generators because it means that a `TypeId`, for example, uniquely
identifies a single generated type. Previously it might refer to one of
two types, either the imported version or the exported version. After
this method, however, there will be two `TypeId`s if necessary.

This is currently modeled as a mutation to `Resolve` which is opt-in.
This is done to avoid tampering with the AST-like structure of `Resolve`
today where other AST-like operations don't want to necessarily have to
keep everything in sync. Once a `Resolve` is nominalized, however, it's
effectively incompatible with other operations such as merging,
printing, etc. My thinking is that for now this is a reasonable tradeoff
as bindings generators can pretty easily invoke this method before
actually running bindings generation.

Closes #1497

* Update MSRV to 1.82

* Fix tests

* Review comments

Author: alexcrichton

Cargo.lock

@@ -104,7 +104,7 @@ version = "0.244.0"
 # message to wasm-tools maintainers to discuss. In some cases it's possible to
 # add version detection to build scripts but in other cases this may not be
 # reasonable to expect.
-rust-version = "1.81.0"
+rust-version = "1.82.0"
 
 [workspace.dependencies]
 ahash = { version = "0.8.11", default-features = false }
@@ -118,9 +118,9 @@ comfy-table = { version = "7.1.3", default-features = false }
 criterion = { version = "0.5.1", default-features = false }
 env_logger = "0.11"
 gimli = "0.31.1"
-hashbrown = { version = "0.15.2", default-features = false, features = ['default-hasher'] }
+hashbrown = { version = "0.16.1", default-features = false, features = ['default-hasher'] }
 id-arena = { version = "2.3.0", default-features = false }
-indexmap = { version = "2.7.0", default-features = false }
+indexmap = { version = "2.13.0", default-features = false }
 indoc = "2.0.5"
 leb128fmt = { version = "0.1.0", default-features = false }
 libfuzzer-sys = "0.4.0"

Cargo.toml

@@ -168,6 +168,7 @@ fn run_one(u: &mut Unstructured<'_>) -> Result<()> {
             funcs
         },
         span: Default::default(),
+        clone_of: None,
     });
 
     // Generate two worlds in our custom package, one for the callee and one for

crates/wit-dylib/tests/roundtrip.rs

@@ -313,6 +313,7 @@ impl<'a> Resolver<'a> {
             functions: IndexMap::default(),
             package: None,
             span,
+            clone_of: None,
         })
     }
 

crates/wit-parser/src/ast/resolve.rs

@@ -912,6 +912,7 @@ impl WitPackageDecoder<'_> {
                     package: None,
                     stability: Default::default(),
                     span: Default::default(),
+                    clone_of: None,
                 })
             });
 
@@ -968,6 +969,7 @@ impl WitPackageDecoder<'_> {
             package: None,
             stability: Default::default(),
             span: Default::default(),
+            clone_of: None,
         };
 
         let owner = TypeOwner::Interface(self.resolve.interfaces.next_id());

crates/wit-parser/src/decoding.rs

@@ -690,6 +690,18 @@ pub struct Interface {
     /// Source span for this interface.
     #[cfg_attr(feature = "serde", serde(skip))]
     pub span: Span,
+
+    /// The interface that this one was cloned from, if any.
+    ///
+    /// Applicable for [`Resolve::generate_nominal_type_ids`].
+    #[cfg_attr(
+        feature = "serde",
+        serde(
+            skip_serializing_if = "Option::is_none",
+            serialize_with = "serialize_optional_id",
+        )
+    )]
+    pub clone_of: Option<InterfaceId>,
 }
 
 impl Interface {