Skip to content

Commit 8da5ce9

Browse files
authored
chore(redux): 表記揺れを修正 (#125)
* chore(npm): update deps * chore(redux): applyMiddlewareに表記統一 fix #116 * chore(redux): 前提の解決 => 依存関係の解決 fix #121 * style(redux): lint errorを修正
1 parent 93bafa4 commit 8da5ce9

4 files changed

Lines changed: 16 additions & 17 deletions

File tree

ja/connect/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,8 @@ app.use("/foo", function fooMiddleware(req, res, next) {
155155
このアーキテクチャでは機能の詳細が _middleware_ で実装できます。
156156
しかし、多くの機能を _middleware_ で実装していくと、 _middleware_ 間に依存関係を作ってしまうことがあります。
157157

158-
この場合、`use(middleware)` で登録する順番により挙動が変わります。
159-
_middleware_ の利用者が、間で起きる前提の解決を行う必要があります
158+
この場合、`use(middleware)` で登録する順番により挙動が変わるため、
159+
利用者が _middleware_ 間の依存関係を解決する必要があります
160160

161161
そのため、プラグイン同士の強い独立性や明確な依存関係を扱いたい場合には不向きといえるでしょう。
162162

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"build": "gitbook build",
2424
"eslint": "eslint src/**/*.js",
2525
"eslint:md": "summary-to-path | xargs eslint -c .md.eslintrc --ext .md",
26-
"textlint": "summary-to-path | xargs textlint --experimental -f pretty-error",
26+
"textlint": "summary-to-path | xargs textlint -f pretty-error",
2727
"test:example": "find ./src -name '*-example.js' | xargs babel-node",
2828
"test:js": "mocha",
2929
"test": "npm-run-all --parallel test:js test:example textlint eslint:md eslint build",
@@ -56,14 +56,14 @@
5656
"jsdom": "^9.2.1",
5757
"lcov-summary": "^1.0.1",
5858
"mocha": "^2.2.5",
59-
"nlcst-to-string": "^1.0.0",
59+
"nlcst-to-string": "^2.0.0",
6060
"node-fetch": "^1.3.2",
6161
"npm-run-all": "^2.1.1",
6262
"power-assert": "^1.4.1",
6363
"redux": "^3.5.2",
64-
"remark": "^4.1.1",
64+
"remark": "^5.0.1",
6565
"stemming-x-keywords": "^1.0.3",
66-
"textlint": "^6.9.0",
66+
"textlint": "^7.0.0",
6767
"textlint-filter-rule-comments": "^1.2.1",
6868
"textlint-formatter-codecov": "^1.0.2",
6969
"textlint-formatter-lcov": "^1.0.2",
@@ -92,6 +92,6 @@
9292
"estraverse": "^4.1.0",
9393
"gulp": "^3.9.0",
9494
"gulp-util": "^3.0.6",
95-
"jquery": "^2.1.4"
95+
"jquery": "^3.0.0"
9696
}
9797
}

src/Redux/apply-middleware.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
=> action - action object
66
77
*/
8-
const applyMiddlewares = (...middlewares) => {
8+
const applyMiddleware = (...middlewares) => {
99
return middlewareAPI => {
1010
const originalDispatch = (action) => {
1111
middlewareAPI.dispatch(action);
@@ -24,4 +24,4 @@ const applyMiddlewares = (...middlewares) => {
2424
};
2525
};
2626

27-
export default applyMiddlewares;
27+
export default applyMiddleware;

test/keywords-test.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
// LICENSE : MIT
22
"use strict";
33
import {getKeywords} from "stemming-x-keywords";
4-
import path from "path";
5-
import fs from "fs";
6-
import remark from "remark";
7-
import parents from "unist-util-parents";
8-
import select from "unist-util-select";
9-
import isUnist from "unist-util-is";
10-
import nlcstToString from "nlcst-to-string";
11-
4+
const fs = require("fs");
5+
const path = require("path");
6+
const remark = require("remark")();
7+
const parents = require("unist-util-parents");
8+
const select = require("unist-util-select");
9+
const isUnist = require("unist-util-is");
10+
const nlcstToString = require("nlcst-to-string");
1211
const rootDir = path.join(__dirname, "..");
1312
const OrganizationText = fs.readFileSync(path.join(rootDir, "README.md"), "utf-8");
1413
function isNotContain(content, keywords) {

0 commit comments

Comments
 (0)