test: use node:assert in commands and generate E2E tests

Replaces error throwing with Node.js assertions in E2E tests.
This provides more informative error messages when tests fail.

Author: clydin

tests/legacy-cli/e2e/tests/commands/add/add-pwa.ts

@@ -1,3 +1,4 @@
+import assert from 'node:assert/strict';
 import { getGlobalVariable } from '../../../utils/env';
 import { expectFileToExist, readFile, rimraf } from '../../../utils/fs';
 import { installWorkspacePackages } from '../../../utils/packages';
@@ -17,9 +18,7 @@ export default async function () {
   const hasPWADep = Object.keys({ ...dependencies, ...devDependencies }).some(
     (d) => d === '@angular/pwa',
   );
-  if (hasPWADep) {
-    throw new Error(`Expected 'package.json' not to contain a dependency on '@angular/pwa'.`);
-  }
+  assert.ok(!hasPWADep, `Expected 'package.json' not to contain a dependency on '@angular/pwa'.`);
 
   const isSnapshotBuild = getGlobalVariable('argv')['ng-snapshots'];
   if (isSnapshotBuild) {
@@ -55,13 +54,10 @@ export default async function () {
   }));
   const emptyAssetGroups = assetGroups.filter(({ urlCount }) => urlCount === 0);
 
-  if (assetGroups.length === 0) {
-    throw new Error("Expected 'ngsw.json' to contain at least one asset-group.");
-  }
-  if (emptyAssetGroups.length > 0) {
-    throw new Error(
-      'Expected all asset-groups to contain at least one URL, but the following groups are empty: ' +
-        emptyAssetGroups.map(({ name }) => name).join(', '),
-    );
-  }
+  assert.ok(assetGroups.length > 0, "Expected 'ngsw.json' to contain at least one asset-group.");
+  assert.ok(
+    emptyAssetGroups.length === 0,
+    'Expected all asset-groups to contain at least one URL, but the following groups are empty: ' +
+      emptyAssetGroups.map(({ name }) => name).join(', '),
+  );
 }

tests/legacy-cli/e2e/tests/commands/add/peer.ts

@@ -1,3 +1,4 @@
+import assert from 'node:assert/strict';
 import { assetDir } from '../../../utils/assets';
 import { ng } from '../../../utils/process';
 
@@ -9,21 +10,15 @@ export default async function () {
     assetDir('add-collection-peer-bad'),
     '--skip-confirmation',
   );
-  if (!bad.includes(warning)) {
-    throw new Error('peer warning not shown on bad package');
-  }
+  assert.match(bad, new RegExp(warning), 'peer warning not shown on bad package');
 
   const { stdout: base } = await ng('add', assetDir('add-collection'), '--skip-confirmation');
-  if (base.includes(warning)) {
-    throw new Error('peer warning shown on base package');
-  }
+  assert.doesNotMatch(base, new RegExp(warning), 'peer warning shown on base package');
 
   const { stdout: good } = await ng(
     'add',
     assetDir('add-collection-peer-good'),
     '--skip-confirmation',
   );
-  if (good.includes(warning)) {
-    throw new Error('peer warning shown on good package');
-  }
+  assert.doesNotMatch(good, new RegExp(warning), 'peer warning shown on good package');
 }

tests/legacy-cli/e2e/tests/commands/add/version-specifier.ts

@@ -1,3 +1,4 @@
+import assert from 'node:assert/strict';
 import { appendFile } from 'node:fs/promises';
 import { expectFileToMatch } from '../../../utils/fs';
 import { getActivePackageManager, uninstallPackage } from '../../../utils/packages';
@@ -21,24 +22,32 @@ export default async function () {
   await expectFileToMatch('package.json', /@angular\/localize/);
 
   const output1 = await ng('add', '@angular/localize', '--skip-confirmation');
-  if (!output1.stdout.includes('Skipping installation: Package already installed')) {
-    throw new Error('Installation was not skipped');
-  }
+  assert.match(
+    output1.stdout,
+    /Skipping installation: Package already installed/,
+    'Installation was not skipped',
+  );
 
   const output2 = await ng('add', '@angular/localize@latest', '--skip-confirmation');
-  if (output2.stdout.includes('Skipping installation: Package already installed')) {
-    throw new Error('Installation should not have been skipped');
-  }
+  assert.doesNotMatch(
+    output2.stdout,
+    /Skipping installation: Package already installed/,
+    'Installation should not have been skipped',
+  );
 
   const output3 = await ng('add', '@angular/localize@19.1.0', '--skip-confirmation');
-  if (output3.stdout.includes('Skipping installation: Package already installed')) {
-    throw new Error('Installation should not have been skipped');
-  }
+  assert.doesNotMatch(
+    output3.stdout,
+    /Skipping installation: Package already installed/,
+    'Installation should not have been skipped',
+  );
 
   const output4 = await ng('add', '@angular/localize@19', '--skip-confirmation');
-  if (!output4.stdout.includes('Skipping installation: Package already installed')) {
-    throw new Error('Installation was not skipped');
-  }
+  assert.match(
+    output4.stdout,
+    /Skipping installation: Package already installed/,
+    'Installation was not skipped',
+  );
 
   await uninstallPackage('@angular/localize');
 }

tests/legacy-cli/e2e/tests/commands/analytics/ask-analytics-command.ts

@@ -1,3 +1,4 @@
+import assert from 'node:assert/strict';
 import { execWithEnv } from '../../../utils/process';
 import { mockHome } from '../../../utils/utils';
 
@@ -17,9 +18,7 @@ export default async function () {
       'n\n' /* stdin */,
     );
 
-    if (!ANALYTICS_PROMPT.test(stdout)) {
-      throw new Error('CLI did not prompt for analytics permission.');
-    }
+    assert.match(stdout, ANALYTICS_PROMPT, 'CLI did not prompt for analytics permission.');
   });
 
   // CLI should skip analytics prompt with `NG_CLI_ANALYTICS=false`.
@@ -31,9 +30,11 @@ export default async function () {
       NG_FORCE_AUTOCOMPLETE: 'false',
     });
 
-    if (ANALYTICS_PROMPT.test(stdout)) {
-      throw new Error('CLI prompted for analytics permission when it should be forced off.');
-    }
+    assert.doesNotMatch(
+      stdout,
+      ANALYTICS_PROMPT,
+      'CLI prompted for analytics permission when it should be forced off.',
+    );
   });
 
   // CLI should skip analytics prompt during `ng update`.
@@ -44,10 +45,10 @@ export default async function () {
       NG_FORCE_AUTOCOMPLETE: 'false',
     });
 
-    if (ANALYTICS_PROMPT.test(stdout)) {
-      throw new Error(
-        'CLI prompted for analytics permission during an update where it should not' + ' have.',
-      );
-    }
+    assert.doesNotMatch(
+      stdout,
+      ANALYTICS_PROMPT,
+      'CLI prompted for analytics permission during an update where it should not have.',
+    );
   });
 }

tests/legacy-cli/e2e/tests/commands/cache/cache-enable-disable.ts

@@ -1,14 +1,19 @@
+import assert from 'node:assert/strict';
 import { readFile } from '../../../utils/fs';
 import { ng } from '../../../utils/process';
 
 export default async function () {
   await ng('cache', 'enable');
-  if (JSON.parse(await readFile('angular.json')).cli.cache.enabled !== true) {
-    throw new Error(`Expected 'cli.cache.enable' to be true.`);
-  }
+  assert.strictEqual(
+    JSON.parse(await readFile('angular.json')).cli.cache.enabled,
+    true,
+    `Expected 'cli.cache.enable' to be true.`,
+  );
 
   await ng('cache', 'disable');
-  if (JSON.parse(await readFile('angular.json')).cli.cache.enabled !== false) {
-    throw new Error(`Expected 'cli.cache.enable' to be false.`);
-  }
+  assert.strictEqual(
+    JSON.parse(await readFile('angular.json')).cli.cache.enabled,
+    false,
+    `Expected 'cli.cache.enable' to be false.`,
+  );
 }