Skip to content

Commit 0d6ad5d

Browse files
committed
Address PR review feedback
1 parent 10b72e4 commit 0d6ad5d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ _Changes on `main` since the latest tagged release that have not yet been includ
1616

1717
### Fixed
1818

19-
- **`query_results_cache_retrieve` rejected by GitHub Copilot Chat (HTTP 400 invalid schema)** — The `lineRange` and `resultIndices` parameters were defined with `z.tuple([...])`, which the MCP SDK serialized to a bare-array JSON Schema value (e.g. `[{"type":"integer"}, {"type":"integer"}]`). GitHub Copilot Chat enforces strict JSON Schema validation and rejected the entire `ql-mcp` server with `"... is not of type 'object', 'boolean'"`. Both parameters now use `z.object({ start, end })` so they serialize to a valid `type: "object"` JSON Schema. Tool callers must now pass `{ "lineRange": { "start": 1, "end": 10 } }` instead of `{ "lineRange": [1, 10] }`. ([#NNN](https://github.com/advanced-security/codeql-development-mcp-server/pull/NNN))
19+
- **`query_results_cache_retrieve` rejected by GitHub Copilot Chat (HTTP 400 invalid schema)** — The `lineRange` and `resultIndices` parameters were defined with `z.tuple([...])`, which the MCP SDK serialized to a bare-array JSON Schema value (e.g. `[{"type":"integer"}, {"type":"integer"}]`). GitHub Copilot Chat enforces strict JSON Schema validation and rejected the entire `ql-mcp` server with `"... is not of type 'object', 'boolean'"`. Both parameters now use `z.object({ start, end })` so they serialize to a valid `type: "object"` JSON Schema. Tool callers must now pass `{ "lineRange": { "start": 1, "end": 10 } }` instead of `{ "lineRange": [1, 10] }`. ([#263](https://github.com/advanced-security/codeql-development-mcp-server/pull/263))
2020

2121
## [v2.25.2] — 2026-04-15
2222

server/test/src/tools/tool-schema-validation.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ vi.mock('../../../src/lib/session-data-manager', () => ({
3434
clearCacheEntries: vi.fn(),
3535
}),
3636
getConfig: vi.fn().mockReturnValue({
37-
storageLocation: '/tmp/test',
37+
storageLocation: '.tmp/test',
3838
autoTrackSessions: false,
3939
retentionDays: 90,
4040
includeCallParameters: false,

0 commit comments

Comments
 (0)