Skip to content

Commit 146905f

Browse files
authored
Remove checked-in binary for test/lld/em_asm_pthread.cpp. NFC (#8392)
This was was added back in #3714, but with a checked in binaryen instead of a .wat file This change fixes `generate_lld_tests.py` so that it can build `em_asm_pthread.cpp` correctly and converts the test from a wasm to a wat test. The important part of the test I beleive is the `(start $__wasm_init_memory)` which exists in the new `.wat` file.
1 parent f914ff7 commit 146905f

6 files changed

Lines changed: 190 additions & 12836 deletions

File tree

scripts/test/generate_lld_tests.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@ def generate_wat_files(llvm_bin, emscripten_sysroot):
6969
# were included.
7070
if 'longjmp' in src_file:
7171
link_cmd.append('--strip-debug')
72+
if 'pthread' in src_file:
73+
compile_cmd.append('-pthread')
74+
link_cmd.append('--import-memory')
75+
link_cmd.append('--shared-memory')
7276
if is_shared:
7377
compile_cmd.append('-fPIC')
7478
compile_cmd.append('-fvisibility=default')

test/lld/em_asm_pthread.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Build with
22
//
3-
// emcc a.cpp -pthread -s WASM_BIGINT
3+
// emcc a.cpp -pthread
44
//
55

66
#include <emscripten.h>

test/lld/em_asm_pthread.wasm

-23.8 KB
Binary file not shown.

0 commit comments

Comments
 (0)